Fix issues with descendants and allDescendants (#3728)

CHANGELOG.md

@@ -7,6 +7,10 @@
 * Enhanced `markdown` component to support the underlying `components` prop from
   `react-markdown`. Use this prop to customize markdown rendering.
 
+### 🐞 Bug Fixes
+* The `Record.descendants` and `Record.allDescendants` getters were incorrectly returning the
+ record itself. This has been fixed.
+
 ## 66.0.2 - 2024-07-17
 
 ### 🐞 Bug Fixes

data/impl/RecordSet.ts

@@ -199,6 +199,7 @@ export class RecordSet {
                     this.store.logDebug(`Attempted to remove non-existent record: ${id}`);
                     return;
                 }
+                allRemoves.add(id);
                 this.gatherDescendantIds(id, allRemoves);
             });
             allRemoves.forEach(it => newRecords.delete(it));
@@ -273,14 +274,13 @@ export class RecordSet {
     }
 
     private gatherDescendantIds(id: StoreRecordId, idSet: Set<StoreRecordId>): Set<StoreRecordId> {
-        if (!idSet.has(id)) {
-            idSet.add(id);
-            const children = this.childrenMap.get(id);
-            if (children) {
-                children.forEach(child => this.gatherDescendantIds(child.id, idSet));
+        this.childrenMap.get(id)?.forEach(child => {
+            if (!idSet.has(child.id)) {
+                // paranoia? did we encounter loops?
+                idSet.add(child.id);
+                this.gatherDescendantIds(child.id, idSet);
             }
-        }
-
+        });
         return idSet;
     }
 }