Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Event Handlers for when we send a message to the server #57

Closed
xforever1313 opened this issue Oct 30, 2020 · 1 comment
Closed

Add Event Handlers for when we send a message to the server #57

xforever1313 opened this issue Oct 30, 2020 · 1 comment

Comments

@xforever1313
Copy link
Owner

We have event handlers that implement from IIrcHandler that are used when we receive messages from the server. However, we should also add events when we send things to the server. This way, we can keep track of the number of messages we send. Perhaps we want to record this in a log or something?

We should have a handler when we send a:

  • Join
  • Part
  • Quit
  • Ping
  • Pong
  • Ctcp Ping
  • Ctcp Pong
  • Notice
  • Action
  • Privmsg
  • All / Raw

Basically, all of our Send() functions on IrcConnection. These events should be put on the StringParsingQueue, and include in them the server we wrote to and the protocol.

xforever1313 added a commit that referenced this issue Nov 1, 2020
Added SendPart events, which is fired when we part from a channel.
xforever1313 added a commit that referenced this issue Nov 1, 2020
Added SendJoin events.
xforever1313 added a commit that referenced this issue Nov 1, 2020
Added an event for when we send a kick message to the server.
xforever1313 added a commit that referenced this issue Nov 1, 2020
PartReason -> Reason.
@xforever1313 xforever1313 self-assigned this Nov 1, 2020
xforever1313 added a commit that referenced this issue Nov 1, 2020
Added handler when we send ALMOST anything to the server.
xforever1313 added a commit that referenced this issue Nov 7, 2020
Added SendCtcpPong event handlers.
xforever1313 added a commit that referenced this issue Nov 7, 2020
Added SendNotice event handler.
xforever1313 added a commit that referenced this issue Nov 8, 2020
Added SendAction event handlers.
xforever1313 added a commit that referenced this issue Nov 8, 2020
Added a SendMessage handler, which gets fired whenever the bot sends a private message (but not ACTION or CTCP) to the server
xforever1313 added a commit that referenced this issue Nov 8, 2020
AllHandler -> ReceiveHandler.
xforever1313 added a commit that referenced this issue Nov 14, 2020
Added an AnyChaskisEvent handler which, well, handles any ChaskisEvent.

This is so ChaskisEvents don't get mixed up in the ReceiveHandler.
xforever1313 added a commit that referenced this issue Nov 14, 2020
Added some unit tests to ensure we fire the send events when we expect to.
xforever1313 added a commit that referenced this issue Nov 14, 2020
Added unit tests to ensure if we send a message via IRC, the send events get fired.
xforever1313 added a commit that referenced this issue Nov 15, 2020
Added another any event that captures any inter-plugin event.

Added it to the RegressionTestPlugin so these events show up in the logs.
@xforever1313
Copy link
Owner Author

All desired events have been added to Chaskis.Core. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant