-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate reconnection logic #27
Comments
Different approach: Let's not handle pings and pongs on the string parsing queue. We don't want to connect/reconnect while the string parsing queue is busy. Instead, we should handle Pings and Pongs directly on the ReaderThread. This also means a user of Chaskis.Core doesn't have to add PingHandler and PongHandler to the list of handlers. This means PingHandler and PongHandler become internal instead of public. This also means if we have multiple connections, we don't have to worry about juggling pings and pongs; everything is self-contained. |
I'm going to close this issue. I think we know what the root-cause of all of this is, and we have a fix. We don't have any regression tests for this, but I'm not sure if its worth the trouble of adding one. Honestly, I wouldn't even know where to begin, there's a lot to add for something that can be clearly seen during code inspection. |
This is spun off of #23. We should figure out how to deal with reconnection. What if the parsing queue is very full, and we don't get a PONG back from the server before it has a chance to tell the watchdog? We'll reconnect for no good reason.
Per #23:
The text was updated successfully, but these errors were encountered: