Expose consumer issue #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to allow for differentiating an invalid user access token from bad consumer creds in
#renew_access_tokencall. Xero gives us this info in the response body fromPOST https://api.xero.com/oauth/AccessTokenvia body params (listed in https://developer.xero.com/documentation/auth-and-limits/oauth-issues), but current impl doesn't distinguish b/w these cases and eats the details.Allowing distinction allows a front-end to prompt a user to re-auth if their access token is bad, but not prompt if the problem is bad consumer creds (as those will continue to fail until a developer/admin fixes the issue). Implementation details swiped from https://github.com/xero-gateway/xero_gateway/blob/master/lib/xero_gateway/http.rb#L90.