Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jmx and debug port mappings. #44

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

anghelutar
Copy link
Contributor

No description provided.

@tgeens
Copy link
Contributor

tgeens commented Nov 19, 2020

Prefer to remove lines over commenting them out ?

@anghelutar anghelutar merged commit 358a025 into master Nov 19, 2020
@anghelutar
Copy link
Contributor Author

In general I agree, I think is best to have fewer comments.
In this case I will leave them, as an example for quickly setting up jmx and debugging (I've seen in the past debugging started up via JAVA_OPTS, when the DEBUG=true option exists in the image; also for jmx is important that the mapped port is 5000, cannot be random port allocated by docker).

@vierbergenlars vierbergenlars deleted the disable-prometheus-solr-integration-tests branch December 10, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants