Solr micrometer #40
Merged
Solr micrometer #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anghelutar
requested review from
tgeens,
vierbergenlars,
thijslemmens and
kerkhofsd
tgeens
reviewed
Nov 16, 2020
tgeens
reviewed
Nov 17, 2020
...lr/common/src/main/java/eu/xenit/alfred/telemetry/solr/monitoring/binder/SolrFTSMetrics.java
Outdated
Show resolved
Hide resolved
tgeens
reviewed
Nov 17, 2020
tgeens
reviewed
Nov 17, 2020
|
Looks a lot cleaner 👍 only the |
tgeens
previously approved these changes
Nov 19, 2020
anghelutar
force-pushed
the
solr-micrometer
branch
from
04f1ea0
to
3cf0762
Compare
Included some default binders + implemented some custom ones. Only Prometheus registry at the moment. Factored out common code in a separate module.
- cumped micrometer version - implemented jmx-based session metrics (the ones from micrometer require a Manager object, which is not present) - refactored jmx code - dashboard for Tomcat - improved Solr dashboard
added 16 commits
November 24, 2020 08:19
Tomcat threads got lost, re-added them.
… they run at fixed ports and will fail if multiple builds run in parallel.
Set the INDEX variable in alfresco so that search works.
Grafana dashboard.
handler. This insures that for graphite metrics are registered. Add SOLR_ENDPOINT as an environment variable. Simplify usage of INDEX in docker-compose. Wait 10s instead of 30s.
Some cleanup.
anghelutar
force-pushed
the
solr-micrometer
branch
from
3cf0762
to
f66bae1
Compare
Make metrics configurable. Environment variables documented in the README.
Co-authored-by: Lars Vierbergen <lars.vierbergen@xenit.eu>
Co-authored-by: Lars Vierbergen <lars.vierbergen@xenit.eu>
Co-authored-by: Lars Vierbergen <lars.vierbergen@xenit.eu>
…into solr-micrometer
|
@tgeens @vierbergenlars If there are no more remarks, approve and merge please. |
tgeens
approved these changes
Nov 26, 2020
|
|
||
| See metrics provided by these modules [here](https://github.com/micrometer-metrics/micrometer/tree/master/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm). | ||
|
|
||
| Note: at the moment GC metrics are not working fully. |
There was a problem hiding this comment.
What is this about exactly ?
There was a problem hiding this comment.
Metrics like jvm_gc_pause_xxx don't work for solr => jvm dashboard for grafana is broken for solr.
Other gc metrics do work: jvm_gc_memory_allocated_xxx.
alfred-telemetry-solr/common/src/main/java/eu/xenit/alfred/telemetry/solr/util/StringUtils.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added micrometer dependencies to alfred-telemetry-solr and rewrote existing Prometheus metrics (and more) with the new framework.
Refactored common code into new module.
Added tomcat-specific metrics: newer version of micrometer required.
Solr + tomcat micrometer-specific dashboards.
Prepare for multiple registries.
To solve: GC metrics.