ALFREDOPS-851 upgrade used Java version to 17 to fix sonarcloud warning

[bartvl-xenit]

No description provided.

[thijslemmens]

On Jenkins, the fixed port was a problem. On GA not really if you don't use the same port twice. Different builds will be on different machines. Op di 21 nov 2023 om 09:06 schreef Zlatin Todorinski < ***@***.***>:

…

***@***.**** requested changes on this pull request. ------------------------------ In integration-tests/src/test/resources/compose/docker-compose-solr.yml <#155 (comment)> : > @@ -17,6 +17,7 @@ services: - DEBUG=true - JMX_ENABLED=true ports: + - "8444:8443" fixed port on a CI/CD is a bad idea ------------------------------ In integration-tests/src/test/java/eu/xenit/alfred/telemetry/integrationtesting/RestAssuredTestSolr.java <#155 (comment)> : > @@ -33,7 +33,7 @@ public static void initializeRestAssured() { final String baseURI = "https://" + System.getProperty("solr.host", "localhost"); RestAssured.baseURI = baseURI; - int port = Integer.parseInt(System.getProperty("solr.tcp.8443", "8443")); + int port = Integer.parseInt(System.getProperty("solr.tcp.8443", "8444")); please revert local change ------------------------------ In alfred-telemetry-platform/build.gradle <#155 (comment)> : > @@ -56,6 +56,7 @@ dependencies { testImplementation "org.hamcrest:hamcrest-all:${hamcrestVersion}" testImplementation "org.awaitility:awaitility:${awaitilityVersion}" testImplementation "org.mockito:mockito-inline:${mockitoVersion}" + testImplementation "net.bytebuddy:byte-buddy:${byteBuddyVersion}" Why was this dependency needed ? — Reply to this email directly, view it on GitHub <#155 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSIMZR7ET3SQ6Q7LKAEE3TYFROI7AVCNFSM6AAAAAA7SRAIEWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBRGMZTANZVGE> . You are receiving this because your review was requested.Message ID: ***@***.***>

not needed