Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharding metrics #85

Closed
anghelutar opened this issue Apr 23, 2021 · 4 comments
Closed

Sharding metrics #85

anghelutar opened this issue Apr 23, 2021 · 4 comments

Comments

@anghelutar
Copy link
Contributor

Currently sharding metrics are enabled by default. This is not the case in most setups and - depending on configuration - Alfresco's logs might be polluted with errors.

Caused by: java.lang.NoSuchMethodError: 'java.util.HashMap org.alfresco.repo.index.shard.ShardRegistry.getFlocs()'

Proposal: by default have the sharding metrics disabled:

alfred.telemetry.binder.solr.sharding.cronexpression=0/10 * * * * ? 2099
alfred.telemetry.binder.solr.sharding.enabled=false
alfred.telemetry.binder.solr.sharding.floc.id.enabled=false
@kerkhofsd
Copy link
Contributor

If I'm not mistaking, that NoSuchMethodError was fixed here?

Does that mean Alfresco injects another, different ShardRegistry in case sharding is not enabled / supported? That sounds very unlikely to me?

@anghelutar
Copy link
Contributor Author

For me simply calling ./gradlew -Penterprise integration-tests:alfresco-enterprise-62:cU triggers that error.

@kerkhofsd
Copy link
Contributor

The fix mentioned before was insufficient.

Map<Floc, HashMap<Shard, HashSet<ShardState>>> still doesn't match the Map<Floc, Map<Shard, Set<ShardState>>> return type.

kerkhofsd pushed a commit that referenced this issue Apr 26, 2021
gh-85 Fix type of SolrShardingMetricsContainer#rawData
ba7031b
kerkhofsd pushed a commit that referenced this issue Apr 26, 2021
gh-85 Invoke ShardRegistry#getFlocs() using reflection
14aa258
kerkhofsd pushed a commit that referenced this issue Apr 27, 2021
gh-85 Fix type of SolrShardingMetricsContainer#rawData
66def69
kerkhofsd pushed a commit that referenced this issue Apr 27, 2021
gh-85 Invoke ShardRegistry#getFlocs() using reflection
b21b55f
anghelutar added a commit that referenced this issue Apr 29, 2021
@anghelutar
Merge pull request #86 from xenit-eu/gh-85
e4239bf 
gh-85 Fix type of SolrShardingMetricsContainer#rawData
Merge confirmed by @kerkhofsd
@kerkhofsd
Copy link
Contributor

Fixed by #86

anghelutar pushed a commit that referenced this issue May 4, 2021
@anghelutar
gh-85 Fix type of SolrShardingMetricsContainer#rawData
f21ce61
anghelutar pushed a commit that referenced this issue May 4, 2021
@anghelutar
gh-85 Invoke ShardRegistry#getFlocs() using reflection
44de253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anghelutar @kerkhofsd