Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config setting for allowfullscreen iframe attribute #38

Closed
xemlock opened this issue Jul 29, 2019 · 3 comments · Fixed by #45
Closed

Add config setting for allowfullscreen iframe attribute #38

xemlock opened this issue Jul 29, 2019 · 3 comments · Fixed by #45
Milestone

Comments

@xemlock
Copy link
Owner

xemlock commented Jul 29, 2019

Related to #37.

Need something similar to HTML.FlashAllowFullScreen.

@bytestream
Copy link
Contributor

Ref: https://fullscreen.spec.whatwg.org/#security-and-privacy-considerations

@xemlock xemlock added this to the 0.1.11 milestone Jul 31, 2019
@xemlock
Copy link
Owner Author

xemlock commented Aug 6, 2019

@bytestream It turns out the additional config option is actually not needed. Iframe is defined in an Iframe module, which is marked as unsafe - it won't be enabled unless HTML.Trusted is explicitly set to true.

The HTML.FlashAllowFullScreen setting is used in SafeObject module, because the module defines <object> tags in safe mode - and only allows carefully filtered subset of params. Unsafe Object module has no such restrictions.

So, the only change required is to define HTML5_Iframe module which inherits from Iframe module, and defines allowfullscreen attribute.

@xemlock
Copy link
Owner Author

xemlock commented Aug 6, 2019

Ok, apparently I was wrong 😅. Iframe can be included not only by setting HTML.Trusted to true, but also by HTML.SafeIframe. In such case the switch (e.g. HTML.IframeAllowFullscreen) is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants