Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Refer new branches to an existing baseline #70

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

raboof
Copy link
Contributor

@raboof raboof commented Jul 8, 2016

though that existing baseline is now hard-coded as '2' :)

though that existing baseline is now hard-coded as '2' :)
@skwakman
Copy link
Contributor

Thanks for the addition @raboof . I've recently fixed the flaky tests on master (was a memory issue on travisCI by the looks of it), so tests are now failing with a good reason. It seems that the branch.clj file is missing. Could you add that one to this PR?

@raboof
Copy link
Contributor Author

raboof commented Jul 31, 2016

@skwakman I merged in master and think I fixed a couple of things, but still see test failures - not completely sure how to read them :)

@raboof
Copy link
Contributor Author

raboof commented Jul 31, 2016

Hmm, I suppose still missing are:

  • default to 'master' when no branch name is provided (might be causing the failing tests)
  • select the right baseline instead of hardcoding '2' :)
  • add tests :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants