buildsystem: honour OBJDIR #481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lib/libxdp/Makefile supports setting of OBJDIR, the directory where compiled object are placed. However when set, linking fails. Set OBJDIR and pass it down the tests, so that linking works if OBJDIR is set. Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
tohojo
reviewed
Feb 24, 2025
| @@ -38,12 +38,12 @@ LIB_OBJS += $(foreach obj,$(UTIL_OBJS),$(LIB_DIR)/util/$(obj)) | |||
| EXTRA_DEPS += | |||
| EXTRA_USER_DEPS += | |||
|
|
|||
| LDFLAGS+=-L$(LIBXDP_DIR) | |||
| LDFLAGS+=-L$(LIBXDP_DIR)/$(OBJDIR) | |||
There was a problem hiding this comment.
This implies that OBJDIR is always relative to LIBXDP_DIR - I am not sure there is any such guarantee? I.e., OBJDIR could be an absolute path?
How were you setting OBJDIR, exactly, when you ran into this?
There was a problem hiding this comment.
Indeed I'm setting OBJDIR=output.
Will take care both both cases OBJDIR is absolute and relative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lib/libxdp/Makefile supports setting of OBJDIR, the directory where compiled object are placed. However when set, linking fails.
Set OBJDIR and pass it down the tests, so that linking works if OBJDIR is set.