Bump to Python 3.9 #100
Merged
Bump to Python 3.9 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
|
Looks good but I think |
cboulay
approved these changes
Apr 16, 2024
|
Yes, I think we should make a new release after this PR is merged (we need a changelog entry then, I'll add one). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we already use
importlib.metadata(the recommended approach), we only caughtImportErrorwhen trying toimport pkg_resources. However, ifsetuptoolsis installed,pkg_resourcescan still be imported, but raise aDeprecationWarning. This PR bumps the minimum required Python version to 3.9, which ships withimportlib.metadata.