Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release GitHub Action #108

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Add release GitHub Action #108

merged 1 commit into from
Jul 17, 2024

Conversation

cbrnr
Copy link
Contributor

@cbrnr cbrnr commented Jul 17, 2024

Fixes #103. This needs to be tested, since I've basically just copied the yml from MNELAB. In particular, we need to make sure that we've added the correct access token to upload to PyPI.

@cbrnr cbrnr mentioned this pull request Jul 17, 2024
@cbrnr
Copy link
Contributor Author

cbrnr commented Jul 17, 2024

I think I've set up the required trusted publisher info in pyxdf's PyPI settings, so maybe we're good to go?

Here's the how-to in case anyone wants to read up on it and check if this PR works correctly:

https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/

@cboulay
Copy link
Contributor

cboulay commented Jul 17, 2024

I don't mind if you stumble through a few minor version bumps while setting up the release. Go ahead and merge and release and let's see!

If you don't want to do that then you can try

with:
    repository-url: https://test.pypi.org/legacy/

(After creating credentials on test.pypi.org for this package)

@cbrnr
Copy link
Contributor Author

cbrnr commented Jul 17, 2024

OK! The risk isn't even that big, because if the upload to PyPI works, everything worked! If there's an issue, I can always delete the tag and force-push (I've done that in some other projects 😄).

@cbrnr cbrnr merged commit aadd062 into xdf-modules:main Jul 17, 2024
5 checks passed
@cbrnr cbrnr deleted the release-gha branch July 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Azure Pipelines with GitHub Actions
2 participants