-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp --follow-exec #962
Merged
Merged
Revamp --follow-exec #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Event log now stores manifest information just to make my tarpaulin-viewer output more compact
I found out posix_spawn causes a call to vfork, I imagine this is the most common time it occurs so should factor that in and put a handle_exec in there
Prototypes compound actions and also handles things being signaled in some manner.
Changes it so we only continue vfork parent in the situation where --forward is passed
Some binaries that are exec'ed and killed may not show as finishing before the root test process, and I'm not sure if they ever will show up? So add a fail-safe merge. Also made signalling less open so only do the TryContinue on SIGTERM
So now we don't have compound events at all, and there is a last_wait_attempt for when the test is finished but tarpaulin is waiting for other things to finish i.e. executables it's getting exec coverage on.
Also, fix debug traces for spawned processes
Timeouts are impossible, and even if `last_wait_attempt` is called we don't want to just launch the entire test binary again _just in case_
This was referenced Mar 8, 2022
When we have nothing in wait queue might as well clear the pending actions queue
xd009642
changed the title
WIP work on integration tests which issue a kill to spawned application
Revamp --follow-exec
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#953