llvm-cov support pt1 #653
Merged
llvm-cov support pt1 #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can confirm doc tests work as expected, two reports generated as there isn't a no-run option for doctests |
xd009642
force-pushed
the
feature/llvm-cov
branch
from
bf6e16d to
66a943a
Compare
Report naming clashes would cause issues with reports being overwritten so now add the process PID into the report filename. Also use a regex to get the version of rust being used and make sure it's >= 1.50.0-nightly
It's currently hardcoded to Ptrace to enable this to be merged but it will allow switching between the two and eventual smart default selection
Added the future TraceEngine option with current options Auto, Llvm and Ptrace. Check it before doing the coverage instrumentation compiler flags and warn if the user selects Llvm but they don't have a current enough compiler
xd009642
force-pushed
the
feature/llvm-cov
branch
from
88e2f0d to
cb9b014
Compare
Rework LLVM cov detection to be contained within the CargoVersionInfo type and refactor tests. Improve version regex to handle stable and beta
Remove llvm args and set engine pre-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress branch for #549. Ideally I'd like to have the parsing of the files done in rust so we don't need to get users to pull in all the llvm tools just to parse a report. Some things that need figuring out: