Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve parameter checks #112

Merged
merged 1 commit into from
Dec 1, 2023
Merged

improve parameter checks #112

merged 1 commit into from
Dec 1, 2023

Conversation

rpreen
Copy link
Member

@rpreen rpreen commented Dec 1, 2023

Fixes #111

Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

30.3% 30.3% Coverage
0.0% 0.0% Duplication

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (2f92d6c) 70.31% compared to head (fb5f3df) 70.26%.

Files Patch % Lines
xcsf/param.c 26.66% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   70.31%   70.26%   -0.05%     
==========================================
  Files          62       62              
  Lines        8904     8913       +9     
  Branches     1076     1079       +3     
==========================================
+ Hits         6261     6263       +2     
- Misses       2643     2650       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpreen rpreen merged commit 9c78c08 into master Dec 1, 2023
8 of 10 checks passed
@rpreen rpreen deleted the 111_improve_param_type_checks branch December 1, 2023 12:39
rpreen added a commit that referenced this pull request Dec 1, 2023
* fix parameter order dependence introduced in #112

* update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spread_min of hyperectangle_csr is not respected (Nested config problem?)
1 participant