-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to @cosmos-client v0.44.4: Prepare for TC hard-fork/Cosmos SDK upgrade #501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since requests in tests are mocked, pls double check all function calls to Cosmos API in "real" life (test-/mainnet) to see if mocks are still returning correct values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm currently integrating the new cosmos-client version to thorwallet react native app. and saw some minor minor improvements you can make.
Hey! Were you able to get the local protobuf stuff working for encoding THORChain's custom MsgSend and MsgDeposit types? I used protobuf.js to generate the type files, but getting errors when broadcasting those messages. You can see in the |
sorry man. as said in discord, waas not working yesterday and didnt see it. |
Steps taken: