Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to @cosmos-client v0.44.4: Prepare for TC hard-fork/Cosmos SDK upgrade #501

Merged
merged 19 commits into from
Mar 19, 2022

Conversation

the-eridanus
Copy link
Collaborator

Steps taken:

  • Upgrade to @cosmos-client/core (new naming of same package): v0.44.4

Copy link
Collaborator

@veado veado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since requests in tests are mocked, pls double check all function calls to Cosmos API in "real" life (test-/mainnet) to see if mocks are still returning correct values.

packages/xchain-cosmos/CHANGELOG.md Outdated Show resolved Hide resolved
packages/xchain-cosmos/CHANGELOG.md Outdated Show resolved Hide resolved
packages/xchain-cosmos/src/client.ts Outdated Show resolved Hide resolved
packages/xchain-thorchain/__tests__/client.test.ts Outdated Show resolved Hide resolved
packages/xchain-thorchain/genMsgDeposit.sh Outdated Show resolved Hide resolved
packages/xchain-thorchain/package.json Outdated Show resolved Hide resolved
packages/xchain-thorchain/src/client.ts Outdated Show resolved Hide resolved
packages/xchain-thorchain/src/client.ts Outdated Show resolved Hide resolved
packages/xchain-thorchain/src/client.ts Show resolved Hide resolved
packages/xchain-thorchain/src/client.ts Show resolved Hide resolved
Copy link
Contributor

@severinwullschleger severinwullschleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm currently integrating the new cosmos-client version to thorwallet react native app. and saw some minor minor improvements you can make.

packages/xchain-cosmos/src/cosmos/sdk-client.ts Outdated Show resolved Hide resolved
packages/xchain-cosmos/src/cosmos/sdk-client.ts Outdated Show resolved Hide resolved
@the-eridanus
Copy link
Collaborator Author

Hi, I'm currently integrating the new cosmos-client version to thorwallet react native app. and saw some minor minor improvements you can make.

Hey! Were you able to get the local protobuf stuff working for encoding THORChain's custom MsgSend and MsgDeposit types? I used protobuf.js to generate the type files, but getting errors when broadcasting those messages. You can see in the xchain-thorchain/src/client transfer and deposit functions how I'm handling it

@severinwullschleger
Copy link
Contributor

Hi, I'm currently integrating the new cosmos-client version to thorwallet react native app. and saw some minor minor improvements you can make.

Hey! Were you able to get the local protobuf stuff working for encoding THORChain's custom MsgSend and MsgDeposit types? I used protobuf.js to generate the type files, but getting errors when broadcasting those messages. You can see in the xchain-thorchain/src/client transfer and deposit functions how I'm handling it

sorry man. as said in discord, waas not working yesterday and didnt see it.

packages/xchain-cosmos/__e2e__/cosmos-client.e2e.ts Outdated Show resolved Hide resolved
packages/xchain-cosmos/src/client.ts Outdated Show resolved Hide resolved
packages/xchain-cosmos/src/cosmos/sdk-client.ts Outdated Show resolved Hide resolved
packages/xchain-cosmos/src/util.ts Outdated Show resolved Hide resolved
packages/xchain-cosmos/src/util.ts Show resolved Hide resolved
packages/xchain-thorchain/README.md Show resolved Hide resolved
packages/xchain-thorchain/src/util.ts Outdated Show resolved Hide resolved
packages/xchain-thorchain/src/util.ts Outdated Show resolved Hide resolved
packages/xchain-thorchain/src/util.ts Outdated Show resolved Hide resolved
packages/xchain-thorchain/src/client.ts Outdated Show resolved Hide resolved
@veado veado merged commit cbbd3de into master Mar 19, 2022
@veado veado deleted the eridanus/issue-398 branch March 19, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants