Merge pull request #937 from xchainjs/931-bnb-derivation-path

BNB Derivation path bug fix and legacy support
xchainjs · Dec 10, 2023 · 0bfaaf6 · 0bfaaf6
2 parents 60a3628 + 0927db5
commit 0bfaaf6
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 8 deletions.
diff --git a/packages/xchain-binance/CHANGELOG.md b/packages/xchain-binance/CHANGELOG.md
@@ -1,3 +1,9 @@
+# v5.7.6 (2023-12-01)
+
+## Update
+
+- Derivation path changed
+
 # v5.7.5 (2023-11-16)
 
 ## Update

diff --git a/packages/xchain-binance/package.json b/packages/xchain-binance/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@xchainjs/xchain-binance",
-  "version": "5.7.5",
+  "version": "5.7.6",
   "description": "Custom Binance client and utilities used by XChainJS clients",
   "keywords": [
     "BNB",
@@ -48,4 +48,4 @@
     "@xchainjs/xchain-crypto": "^0.3.0",
     "@xchainjs/xchain-util": "^0.13.1"
   }
-}
+}
diff --git a/packages/xchain-binance/src/client.ts b/packages/xchain-binance/src/client.ts
@@ -95,9 +95,9 @@ class Client extends BaseXChainClient implements BinanceClient, XChainClient {
     network = Network.Mainnet,
     phrase,
     rootDerivationPaths = {
-      [Network.Mainnet]: "44'/931'/0'/0/",
-      [Network.Stagenet]: "44'/931'/0'/0/",
-      [Network.Testnet]: "44'/931'/0'/0/",
+      [Network.Mainnet]: "44'/714'/0'/0/",
+      [Network.Stagenet]: "44'/714'/0'/0/",
+      [Network.Testnet]: "44'/714'/0'/0/",
     },
   }: XChainClientParams) {
     super(BNBChain, { network, rootDerivationPaths, phrase })

diff --git a/packages/xchain-thorchain-amm/CHANGELOG.md b/packages/xchain-thorchain-amm/CHANGELOG.md
@@ -1,3 +1,9 @@
+# v0.8.8 (2023-12-08)
+
+## Update
+
+- Binance client version updated
+
 # v0.8.7 (2023-12-07)
 
 ## Update

diff --git a/packages/xchain-thorchain-amm/package.json b/packages/xchain-thorchain-amm/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@xchainjs/xchain-thorchain-amm",
-  "version": "0.8.7",
+  "version": "0.8.8",
   "description": "module that exposes estimating & swappping cryptocurrency assets on thorchain",
   "keywords": [
     "THORChain",
@@ -40,7 +40,7 @@
     "@cosmos-client/core": "0.46.1",
     "@psf/bitcoincashjs-lib": "^4.0.3",
     "@xchainjs/xchain-avax": "^0.4.1",
-    "@xchainjs/xchain-binance": "^5.7.5",
+    "@xchainjs/xchain-binance": "^5.7.6",
     "@xchainjs/xchain-bitcoin": "^0.23.7",
     "@xchainjs/xchain-bitcoincash": "^0.17.5",
     "@xchainjs/xchain-client": "^0.15.5",
@@ -76,7 +76,7 @@
     "@cosmos-client/core": "0.46.1",
     "@psf/bitcoincashjs-lib": "^4.0.3",
     "@xchainjs/xchain-avax": "^0.4.1",
-    "@xchainjs/xchain-binance": "^5.7.5",
+    "@xchainjs/xchain-binance": "^5.7.6",
     "@xchainjs/xchain-bitcoin": "^0.23.7",
     "@xchainjs/xchain-bitcoincash": "^0.17.5",
     "@xchainjs/xchain-client": "^0.15.5",