Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix configeth does not reload new ifcfg-* for installnic when diskless/statelite node reboot #6029

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

bybai
Copy link
Contributor

@bybai bybai commented Feb 22, 2019

The PR is to fix issue

#6028

The modification include

configeth will reload new ifcfg-* for installnic when diskless/statelite node reboot

The UT result

  1. Reboot diskless node, and check xcat.log, confignetwork runs.
Fri Feb 22 04:16:23 EST 2019 [info]: xcat.deployment.postbootscript: postbootscript start..: confignetwork
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
[I]: configure the install nic eth0.
[I]: configeth on byrh07: os type: redhat
['/etc/sysconfig/network-scripts/ifcfg-eth0']
[I]: >> DEVICE=eth0
[I]: >> IPADDR=10.4.41.7
[I]: >> NETMASK=255.0.0.0
[I]: >> BOOTPROTO=none
[I]: >> ONBOOT=yes
[I]: >> HWADDR=42:66:0a:04:29:07
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  1. check install nic is not dynamic configured
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP qlen 1000
    link/ether 42:66:0a:04:29:07 brd ff:ff:ff:ff:ff:ff
    inet 10.4.41.7/8 brd 10.255.255.255 scope global eth0
       valid_lft forever preferred_lft forever
    inet6 fe80::4066:aff:fe04:2907/64 scope link
       valid_lft forever preferred_lft forever

@bybai bybai requested a review from robin2008 February 22, 2019 09:33
@bybai bybai added this to the 2.14.6 milestone Feb 22, 2019
Copy link
Member

@robin2008 robin2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@robin2008 robin2008 merged commit 56c21ed into xcat2:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants