Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXECUTE in sync list will not invoke post sync scripts if the script itself is updated #6001

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

immarvin
Copy link
Contributor

The PR is to correct the behavior in PR #5997:

The update of post sync script file <file-to-sync>.post will not trigger the invocation of <file-to-sync>.post for EXECUTE clause

UT:

[root@boston36 xCAT]# cat /install/custom/synclist
/etc/test -> /tmp/etc/test
/etc/test.post -> /tmp/test.post
EXECUTE:
/etc/test.post

[root@boston36 xCAT]# cat /install/custom/synclist
/etc/test -> /tmp/etc/test
/etc/test.post -> /tmp/test.post
EXECUTE:
/etc/test.post
[root@boston36 xCAT]# xdcp mid21tor24cn01 -v -T -F /install/custom/synclist
TRACE:Default context is XCAT.
TRACE:Fanout Value is 64.
TRACE:Timeout Value is .
TRACE:Verifying remaining targets with pping command.
 TRACE: Executing Command:/bin/sh -c /tmp/rsync_mid21tor24cn01

[root@boston36 xCAT]# touch /etc/test.post
[root@boston36 xCAT]# xdcp mid21tor24cn01 -v -T -F /install/custom/synclist
TRACE:Default context is XCAT.
TRACE:Fanout Value is 64.
TRACE:Timeout Value is .
TRACE:Verifying remaining targets with pping command.
 TRACE: Executing Command:/bin/sh -c /tmp/rsync_mid21tor24cn01

[root@boston36 xCAT]# touch /etc/test
[root@boston36 xCAT]# xdcp mid21tor24cn01 -v -T -F /install/custom/synclist
TRACE:Default context is XCAT.
TRACE:Fanout Value is 64.
TRACE:Timeout Value is .
TRACE:Verifying remaining targets with pping command.
 TRACE: Executing Command:/bin/sh -c /tmp/rsync_mid21tor24cn01
TRACE:Default context is XCAT
TRACE:Node RSH is
TRACE: Fanout value is 64.
TRACE: Timeout value is
TRACE: Verify value is
TRACE: Execute option specified.
TRACE:Execute: Exporting File:/usr/bin/scp -B /etc/test.post root@mid21tor24cn01:/tmp/Fb9lLdGrEN.dsh
Command name: /usr/bin/ssh -o BatchMode=yes -x root@mid21tor24cn01 export NODE=mid21tor24cn01; export LANG=en_US.UTF-8 LC_CTYPE="C" LC_NUMERIC="C" LC_TIME="C" LC_COLLATE="C" LC_MONETARY="C" LC_MESSAGES="C" LC_PAPER="C" LC_NAME="C" LC_ADDRESS="C" LC_TELEPHONE="C" LC_MEASUREMENT="C" LC_IDENTIFICATION="C" LC_ALL=C PERL_BADLANG=0 ;  /tmp/Fb9lLdGrEN.dsh ; export DSH_TARGET_RC=$?; echo ":DSH_TARGET_RC=${DSH_TARGET_RC}:";rm /tmp/Fb9lLdGrEN.dsh
[root@boston36 xCAT]#

@robin2008 robin2008 merged commit 67d5cae into xcat2:master Feb 20, 2019
immarvin added a commit to immarvin/xcat-core that referenced this pull request Feb 21, 2019
immarvin added a commit to immarvin/xcat-core that referenced this pull request Feb 21, 2019
immarvin added a commit to immarvin/xcat-core that referenced this pull request Feb 21, 2019
hu-weihua pushed a commit that referenced this pull request Feb 21, 2019
fix issue PR #6001 resulted in test case updatenode_syncfile_EXECUTE failed #6016
jjohnson42 pushed a commit to jjohnson42/xcat-core that referenced this pull request Apr 4, 2019
jjohnson42 pushed a commit to jjohnson42/xcat-core that referenced this pull request Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants