Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix enablekdump for redhat7.6 and 7.6-alt nfs vers 4 support #5713

Merged
merged 3 commits into from
Oct 18, 2018

Conversation

bybai
Copy link
Contributor

@bybai bybai commented Oct 17, 2018

The PR is to fix issue

#5712

The modification include

nfs vers in redhat7.6 and 7.6-alt is 4, enablekdump hard code mount -o vers=3 ..., this cause error like:

[root@f5u14 ~]# /bin/mount -o vers=3 10.6.13.10:/kdumpdir /root/bai
mount.nfs: requested NFS version or transport protocol is not supported

The UT result

After this fix, UT:

[root@c910f03c09k09 postscripts]# updatenode c910f03c09k11 enablekdump
c910f03c09k11: vpdupdate is not supported on the pSeries KVM Guest platform
c910f03c09k11: updating VPD database
c910f03c09k11: trying to download postscripts...
c910f03c09k11: postscripts downloaded successfully
c910f03c09k11: trying to get mypostscript from 10.3.9.9...
c910f03c09k11: Running postscript: enablekdump
c910f03c09k11: ++ /usr/sbin/rpcinfo -p 10.3.9.9
c910f03c09k11: ++ grep -w nfs
c910f03c09k11: ++ awk '/tcp/{print $2}'
c910f03c09k11: ++ sort
c910f03c09k11: + nfsvers='3
c910f03c09k11: 4'
c910f03c09k11: + nfsver=0
c910f03c09k11: + '[' -n '3
c910f03c09k11: 4' ']'
c910f03c09k11: + for i in '$nfsvers'
c910f03c09k11: + '[' 3 -eq 3 ']'
c910f03c09k11: + '[' grep -w nfs /proc/filesystems ']'
c910f03c09k11: + nfsver=3
c910f03c09k11: + break
c910f03c09k11: + '[' 3 -ne 0 ']'
c910f03c09k11: + /bin/mount -o vers=3 10.3.9.9:/kdumpdir /mnt
c910f03c09k11: + set +x
c910f03c09k11: postscript: enablekdump exited with code 0
c910f03c09k11: Running of postscripts has completed.

@bybai bybai requested a review from robin2008 October 17, 2018 09:43
@bybai bybai added this to the 2.14.5 milestone Oct 17, 2018
break
fi
done
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to print a message when no NFS server ready.

fi
done
fi
if [ $nfsver -ne 0 ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only mount when nfs server is okay.

@robin2008 robin2008 merged commit 7b68047 into xcat2:master Oct 18, 2018
@robin2008 robin2008 modified the milestones: 2.14.5, 2.14.4 Oct 18, 2018
@bybai bybai deleted the kdumptt branch October 31, 2018 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants