Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PVR] Fix missing 'mark watched'/'mark unwatched' context menu entries for recordings folders. #16939

Merged
merged 1 commit into from
Nov 19, 2019
Merged

[PVR] Fix missing 'mark watched'/'mark unwatched' context menu entries for recordings folders. #16939

merged 1 commit into from
Nov 19, 2019

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Nov 18, 2019

Fixes a regression introduced with 7239c68

Before:
screenshot001

After:
screenshot002

@phunkyfish good to go?

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: PVR v19 Matrix labels Nov 18, 2019
@ksooo ksooo added this to the Matrix 19.0-alpha 1 milestone Nov 18, 2019
@ksooo ksooo requested a review from phunkyfish November 18, 2019 17:28
phunkyfish
phunkyfish approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good. But do we also need to fix URIUtils::IsPVRRecording?

@phunkyfish
Copy link
Contributor

Or maybe better to ask the question should URIUtils work here?

@ksooo
Copy link
Member Author

ksooo commented Nov 18, 2019

Or maybe better to ask the question should URIUtils work here?

URIUtils cannot decide on this, as it works only on the path and there is no possibility to determine from the path whether path in question is a folder or a file. :-(

@phunkyfish
Copy link
Contributor

Ok, fair. Confusing, but fair.

@phunkyfish
Copy link
Contributor

phunkyfish commented Nov 18, 2019 •
edited
Loading

URIUtils::IsPVRRecordingFileOrFolder()???

@ksooo
Copy link
Member Author

ksooo commented Nov 18, 2019

URIUtils::IsPVRRecordingFileOrFolder()

Would make things more clear, yes. Come up with a PR if you like.

@ksooo
Copy link
Member Author

ksooo commented Nov 19, 2019

jenkins build this please

@ksooo
Copy link
Member Author

ksooo commented Nov 19, 2019

WIN-UWP-64 jenkins error is unrelated.

@ksooo ksooo merged commit 3933aee into xbmc:master Nov 19, 2019
@ksooo ksooo deleted the pvr-fix-recordings-folders-context-menu branch November 19, 2019 09:24
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jan 21, 2020
@ksooo @Maven85
Merge pull request xbmc#16939 from ksooo/pvr-fix-recordings-folders-c…
c1b2e9e 
…ontext-menu

[PVR] Fix missing 'mark watched'/'mark unwatched' context menu entries for recordings folders.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phunkyfish phunkyfish phunkyfish approved these changes

Assignees
No one assigned
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-alpha 1
Development

Successfully merging this pull request may close these issues.
2 participants
@ksooo @phunkyfish