Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script.service.hyperion-control@nexus] 20.0.0 #2502

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

Lord-Grey
Copy link

Add-on details:

Enable and disable components (like capture) of Hyperion automatically based on playing/screensaver state of Kodi[CR]-Supports auto detection of Hyperion Servers[CR]-Token authentication

Description of changes:

  20.0.0
  - Kodi 20 (Nexus) support
  - major refactor to adhere to SOLID principles

  19.0.2
  - New languages: Español, Français, Polski

  19.0.1
  - Kodi 19 support
  - minor cleanups and corrections

  1.0.1
  - Fixed a crash with 3d mode @b-jesch

  1.0.0
  - Added support for server search
  - Added support token authentication
  - Fixed issue where kodi api does not properly announce video playing states

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the minor comment I think the fanart cannot have transparency. This affects the overall Kodi GUI performance
Thanks for the update

script.service.hyperion-control/addon.xml Outdated Show resolved Hide resolved
script.service.hyperion-control/resources/__init__.py Outdated Show resolved Hide resolved
@Lord-Grey
Copy link
Author

@enen92 Thanks for the feedback. All requested changes are done.
May I ask for another review, please?
Thank you!

@Lord-Grey Lord-Grey requested a review from enen92 August 3, 2023 18:12
Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks for adjusting the minors.
Have a good one

@enen92 enen92 merged commit e29c2d1 into xbmc:nexus Aug 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants