Mark radio.de addon as broken #4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gade01 @yol @anxdpanic @MartijnKaijser Are you guys OK with this? |
|
It looks like I have to bump the version, I'd say the correct one would be |
Indeed. Or make it |
georgkrause
force-pushed
the
broken-radio_de
branch
from
4f2a56a to
19d03a9
Compare
|
But if the plugin eventually releases v3.0.10 we would be in trouble. I therefore decided for v3.0.9-matrix.2 |
|
Then they need to bump it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As reported in #4568 the addon is not working anymore. The issue was reported to the projects issue tracker already, however its months now and there wasn't any reaction. I expect the plugin to be broken for a while, even though I actually plan to debug and eventually fix the issue. Until this is done, its only fair not to let people install the addon if its not working anyways.
I am not sure if I have to bump the version in order to mark it as broken. If there is something missing, let me know and I am happy to touch up!
Checklist: