Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX improvements #124

Merged
merged 33 commits into from
May 1, 2024
Merged

UX improvements #124

merged 33 commits into from
May 1, 2024

Conversation

lukarenko
Copy link
Collaborator

@lukarenko lukarenko commented Apr 30, 2024 •
edited
Loading

Description

arrivals-departures:

  • distance/duration column with numerical sort
  • search now works
  • export moved below table

logs:

  • search text also in to and from moorage name
  • cards: center label:value pairs

stays-moorage:

  • search filter
  • sortable duration column
  • by default sort from newest to oldest
  • added stayed_at to CSV export (converted from id)
  • remove export GPX/GeoJSON as not useful for single moorage

moorages:

  • move days to column name for total stays
  • default sort by total stay

stays:

  • fix arrived/departed column names

monitoring-history:

  • remove misleading filter title

monitoring-explore:

  • remove title
  • clearable search field
  • remove Reset button (did nothing)

units:

  • miles -> NM
  • knots -> kts
  • decimals: 1 for days, NM and kts, 2 for hours

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

lukarenko added 16 commits April 30, 2024 15:15
@lukarenko
arrivals-departures: ux fix
1e952cc 
- hide search as it does not work when filter for specific moorage is applied
- distance/duration columns with num sort
- move sortNum() to utils for reuse
@lukarenko
arrivals-departures: add search back
42ce2c0 
- make it work
@lukarenko
Logs: text search also for from and to moorage name
6808aef
@lukarenko
Stays Moorage: ux fixes
ee619d4 
- search UX: only support date filter for now
- sortable Duration column
@lukarenko
Remove log.console
4406097
@lukarenko
Stays: fix duration sort, CSV column names
6932670 
also remove duration_unit from i18n as not used
@lukarenko
Stays-Moorage: remove export GPX, GeoJSON
2743c33 
Does not make sense, as this page displays all stays at one single moorage (one location), does not make sense to export GeoJSON.
@lukarenko
Stays on Moorage: sort from newest to oldest
e400819
@lukarenko
Moorages: sorting, column name
97c99e0
@lukarenko
Stays: fix Arrived/Departed column name
9d53fbe
@lukarenko
Stays - Moorage: add StayedAt to CSV export
d251a6f 
- was missing in data (just ID)
@lukarenko
StaysAt: optimized version with hash
0e353fd
@lukarenko
Monitoring History: remove misleading title on time filter
a54675d
@lukarenko
Monitoring-History: clearable search field, remove Reset (did nothing)
154094c
@lukarenko
Cleanup code
5577877
@lukarenko
StayAt export fixes/refac
27f8b17
@lukarenko lukarenko requested a review from xbgmsharp April 30, 2024 19:21
@xbgmsharp xbgmsharp merged commit 881ae67 into live May 1, 2024
3 checks passed
@xbgmsharp
Copy link
Owner

Awesome thanks

@xbgmsharp xbgmsharp deleted the search-ux branch May 1, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xbgmsharp xbgmsharp Awaiting requested review from xbgmsharp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukarenko @xbgmsharp