TY-2194 code generation parts [2]

[rustonaut]

No description provided.

[janpetschexain]

this currently even fails to check:

cargo check
    Updating git repository `ssh://git@github.com/xaynetwork/xayn_dart_api_dl.git`
error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`

Caused by:
  failed to load source for dependency `xayn-dart-api-dl`

Caused by:
  Unable to update ssh://git@github.com/xaynetwork/xayn_dart_api_dl.git?branch=TY-2221-2-bindings-for-dart-api-dl-h

Caused by:
  failed to fetch into: /Users/janpetsche/.cargo/git/db/xayn_dart_api_dl-0480252925562bf4

Caused by:
  failed to authenticate when downloading repository

  * attempted ssh-agent authentication, but no usernames succeeded: `git`

  if the git CLI succeeds then `net.git-fetch-with-cli` may help here
  https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli

Caused by:
  no authentication available

[janpetschexain]

it seems unnecessary that the macro takes its arguments by value, is there a temporary reference issue? (can't check myself because code doesn't compile)

Suggested change

	let left = $left;
	let mut left = $crate::test_utils::trimmed_non_empty_lines(&left);
	let right = $right;
	let mut right = $crate::test_utils::trimmed_non_empty_lines(&right);
	let mut left = $crate::test_utils::trimmed_non_empty_lines(&$left);
	let mut right = $crate::test_utils::trimmed_non_empty_lines(&$right);

[rustonaut]

Though assert statements in general get called with values all the time and then there would be an temporary reference issue and requiring an explicit referencing of values isn't good UX while an additional & normally doesn't cause problems.

[rustonaut]

this currently even fails to check

it fails to access the private repository, i.e. it fails before it even comes to checking.

To access private repositories as dependencies with cargo you need to have a running ssh agent.

Git CLI has a workarounds for the case no ssh-agent is running, but a .ssh folder with keys exists.
libgit used by cargo doesn't support that.

You can either:

• setup an ssh agent
• set the CARGO_NET_GIT_FETCH_WITH_CLI env variable to true to force cargo to use git CLI.
• or in ~/.cargo/config add

  [net]
  git-fetch-with-cli = true

Related issues:

• Support .ssh/config for specifying keys if ssh-agent fails rust-lang/cargo#2078

I also had to do this in the CI.

I originally wanted to make the repos public before the holidays, but thinks got in the way (like the whole thing about how to license things).

[rustonaut]

Be ware that due to the limitations mentioned in the (pre-)previous daily you might need to run cargo check once where it fails before being able to properly check it. Your IDE will probably do it for you. But that's why there is e.g. an

cargo check --quiet 2>/dev/null in test.sh

[Robert-Steiner]

looks good 👍 Just a few suggestions/questions
I was also able to run test.sh script

[Robert-Steiner]

would it make sense to use consthere?

[rustonaut]

sure, I'm now wondering if it actually makes a difference in the generated code. 🤔

Like at least most times due to the nature of &str it makes sense for rust to generate roughly the same code for const strings of it as it does for statics ones ,I think (i.e. place it once in the executable in read-only memory and reference it from there).

And while it could optimize some pointer address comparisons differently, you probably don't run into them in rust in this context most of the times.

Anyway const is stylistically more appropriate for this use-cases so I switched to it.

[Robert-Steiner]

I was also not sure if this makes any difference 😅

Anyway const is stylistically more appropriate for this use-cases so I switched to it.

👍

handover