Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump all packages and actions #174

Merged
merged 8 commits into from
Jun 3, 2023
Merged

Bump all packages and actions #174

merged 8 commits into from
Jun 3, 2023

Conversation

scottyhq
Copy link
Contributor

@scottyhq scottyhq commented Jun 2, 2023

major changes:

  • python 3.11
  • xarray 2023.5.0
  • jupyterbook 0.15.2

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@scottyhq
Copy link
Contributor Author

scottyhq commented Jun 2, 2023

All green! FYI In order to lock the environment for osx-64 I had to use conda 22.9 (conda/conda-lock#408),,, seems like it'll be fixed for next release of conda.

@scottyhq scottyhq requested a review from lsetiawan June 2, 2023 21:48
Copy link
Member

@lsetiawan lsetiawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @scottyhq! Can you also specify the package version for jupyter-book and xarray in the environment-unpinned.yml? I know you have the more specific ones in environment.yml but for the sake of those that has the new Mac M1/M2 machines, I can't use those and have to use the unpinned yml file. So to ensure that we get the same versions, it's probably good to pin at least the xarray version and jupyter book to minimize headaches for participants in case the upstream package updates before July 😛 Thanks!

@scottyhq
Copy link
Contributor Author

scottyhq commented Jun 2, 2023

for the sake of those that has the new Mac M1/M2 machines

I thought in theory the lock for -p osx-arm64 was for these fancy new machines :)

conda-lock lock --mamba -f environment-unpinned.yml -p osx-64 -p linux-64 -p win-64 -p osx-arm64

@lsetiawan from the conda folder can you try conda-lock install -n xarray-tutorial or micromamba create -n xarray-tutorial -f conda-lock.yml I definitely think we should push people towards a binderhub for the scipy tutorial to avoid these complications.

@lsetiawan
Copy link
Member

Ah. I haven't used much of conda lock and it's Friday afternoon. I guess that's my issue 😉 Sounds good. I agree in pushing people towards binderhub. Thanks for the explanation 😄

@scottyhq scottyhq merged commit 0080f9f into main Jun 3, 2023
@scottyhq scottyhq deleted the env2023 branch June 3, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants