-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use engine flox for ordered groups #266
Merged
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
ef6bbc4
use engine flox for ordered groups
mathause e0ea569
Add issorted helper func
dcherian d4e30d8
Some fixes
dcherian c8000e3
In xarray too
dcherian 68edd74
Merge remote-tracking branch 'upstream/main' into engine_none
dcherian c483a1a
formatting
dcherian 3e4bae9
simplify
dcherian d14299a
Merge remote-tracking branch 'upstream/main' into engine_none
dcherian 92eaf2c
retry
dcherian 1a230eb
flox
dcherian 22bd20c
minversion numabgg
dcherian 699ecd9
cleanup
dcherian 3d6413f
fix type
dcherian 7061fda
Merge branch 'main' into engine_none
dcherian 443fbc2
update gitignore
dcherian eedeb8e
add types
dcherian cc90509
Fix env?
dcherian 56957a1
fix
dcherian 16d4393
fix merge
dcherian f6262d2
cleanup
dcherian 12dc816
Merge branch 'main' into engine_none
dcherian e13c2d9
[skip-ci] bench
dcherian a7cd95c
Merge branch 'main' into engine_none
dcherian 46262f0
temporarily disable numbagg
dcherian ed8bd51
don't cache env
dcherian db0a6cc
Finally!
dcherian 90cecf8
bugfix
dcherian f2e0aa6
Fix doctest
dcherian 39c19b8
more fixes
dcherian 7126e60
Fix CI
dcherian 1243903
readd numbagg
dcherian 524f540
Merge remote-tracking branch 'upstream/main' into engine_none
dcherian b70b0e6
Merge branch 'main' into engine_none
dcherian 3534766
Fix.
dcherian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,7 +72,7 @@ def xarray_reduce( | |
fill_value=None, | ||
dtype: np.typing.DTypeLike = None, | ||
method: str = "map-reduce", | ||
engine: str = "numpy", | ||
engine: str = None, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again needs docstring update. |
||
keep_attrs: bool | None = True, | ||
skipna: bool | None = None, | ||
min_count: int | None = None, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a docstring update.