Add larger bit depth for displaying flag_masks #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Underlying cf flag_mask codes (eg. == and .isin) work with flag_masks with more than 8 independent flags (eg. uint32), however the formatting codes that print messages to the screen are limited to uint8. Add/modify functions to unpack bits from larger integer dtypes.
Original formatting widths work well for 8-bit flag_masks, but need some modification for larger integer values.
bit_length is re-calculated a second time inside _unpacked_bits, which can lead to incorrect bit_length. Pass this value as an argument instead, since it was properly calculated earlier in the process.
Flags do not have to be unsigned. For example, "basin" test dataset will fail the unsigned integer test even though it contains valid int64 flags.
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
=======================================
Coverage 93.93% 93.94%
=======================================
Files 12 12
Lines 1699 1717 +18
=======================================
+ Hits 1596 1613 +17
- Misses 103 104 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks, this LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add larger bit depth support for displaying the flags / flag_masks as in #491 . Thank you for considering this.