CP-53692 SR attach calls mpathcount async #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lunfan Zhang <Lunfan.Zhang@cloud.com>
|
I think it's fine that mpathcount no longer takes a parameter, I think we did away with that when it was converted to a kickpipe service. |
MarkSymsCtx
approved these changes
Mar 20, 2025
KevinLCtx
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kickpipe as subprocess to run mpathcount script in the background to avoid the synchronously calling block the SR attach process.
The original implementation will pass a
SCSIidto the mpathcount script, however I think this script will not handler a extra parameter at the moment. so it is an unnecessary parameter.BST - 214740
Limit configure test - 21474