Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mtouch] Move native code sharing check for the remove-dynamic-registrar optimization until after checking the linker settings. #3643

Merged
merged 1 commit into from
Mar 2, 2018
Merged

[mtouch] Move native code sharing check for the remove-dynamic-registrar optimization until after checking the linker settings. #3643

merged 1 commit into from
Mar 2, 2018

Commits on Mar 2, 2018

  1. [mtouch] Move native code sharing check for the remove-dynamic-regist… 

    …rar optimization until after checking the linker settings.

Fixes this test failure:

1) Failed : Xamarin.MTouch.MT0113_linker
The error 'MT0113: Native code sharing has been disabled for the extension 'testServiceExtension' because the managed linker settings are different between the container app (None) and the extension (All).' was not found in the output:
	Message #1 did not match:
		actual:   'Native code sharing has been disabled for the extension 'testServiceExtension' because the remove-dynamic-registrar optimization differ between the container app (default) and the extension (false).'
		expected: 'Native code sharing has been disabled for the extension 'testServiceExtension' because the managed linker settings are different between the container app (None) and the extension (All).'

which happens because:

* Removing the dynamic registrar requires the linker, so removal of the dynamic registrar is disabled if the linker is not disabled
* This results in the app and appex having different values for the remove-dynamic-registrar option
* Thus the error message.

Technically either error is correct, but I prefer the previous one (about the
linker), because it directly assigns blame (the linker setting). Figuring out
what has to change (the linker setting) when the error message complains about
an optimization is not so straight forward for users.
    @rolfbjarne
    rolfbjarne committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    6da5aa7 View commit details
    Browse the repository at this point in the history