Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xamarin-analysis] Add rule #6 and updated md file #3088

Merged
merged 1 commit into from
Dec 12, 2017
Merged

[xamarin-analysis] Add rule #6 and updated md file #3088

merged 1 commit into from
Dec 12, 2017

Conversation

VincentDondain
Copy link
Contributor

  • Add XIA0006: HttpClientAvoidManaged.
  • Add documentation on how the rules work and how to activate them.
    Also mention that they need to be ran on each active configuration.
  • Bump maccore to include XIA 0006.

@VincentDondain
[xamarin-analysis] Add rule xamarin#6 and updated md file
4444d82 
- Add XIA0006: HttpClientAvoidManaged.
- Add documentation on how the rules work and how to activate them.
  Also mention that they need to be ran on each active configuration.
- Bump maccore to include XIA 0006.
@VincentDondain VincentDondain added the do-not-merge Do not merge this pull request label Dec 7, 2017
@VincentDondain
Copy link
Contributor Author

dont-merge because the bots are currently down (:

spouliot
spouliot approved these changes Dec 8, 2017
View reviewed changes
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be added to 11.7 release notes in the wiki

@VincentDondain
Copy link
Contributor Author

@spouliot done here https://github.com/xamarin/xamarin-macios/wiki/xamarin.ios_11.7#xamarinanalysis

@monojenkins
Copy link
Collaborator

Build success

@VincentDondain VincentDondain removed the do-not-merge Do not merge this pull request label Dec 12, 2017
@VincentDondain
Copy link
Contributor Author

https://jenkins.mono-project.com/view/Xamarin.MaciOS/job/xamarin-macios-pr-builder/5753/

@VincentDondain VincentDondain merged commit 79e1d36 into xamarin:master Dec 12, 2017
@VincentDondain VincentDondain deleted the xia-0006-update branch December 12, 2017 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

@rolfbjarne rolfbjarne Awaiting requested review from rolfbjarne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VincentDondain @monojenkins @spouliot @dnfadmin @dnfclas