Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Use Identity instead of FullPath on _CompressObjCBindingNativeFrameworkResources target #2499

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

emaf
Copy link
Contributor

@emaf emaf commented Aug 16, 2017

Using the FullPath property breaks the build from Windows, since the metadata will contain a Windows path.

Partial fix for Bug #51759 - Getting build error for iOS sample 'Simpleapp-with-framework'

https://bugzilla.xamarin.com/show_bug.cgi?id=51759

…rameworkResources target

Using the FullPath property breaks the build from Windows, since the metadata will contain a Windows path.

Partial fix for Bug #51759 - Getting build error for iOS sample 'Simpleapp-with-framework'

https://bugzilla.xamarin.com/show_bug.cgi?id=51759
@emaf emaf requested review from rolfbjarne and spouliot August 16, 2017 14:44
@monojenkins
Copy link
Collaborator

Build failure

@spouliot
Copy link
Contributor

build

@monojenkins
Copy link
Collaborator

Build success

@spouliot spouliot merged commit 4e0c545 into xamarin:master Aug 17, 2017
rolfbjarne added a commit that referenced this pull request Aug 26, 2021
New commits in xamarin/maccore:

* xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504)
* xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503)
* xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502)
* xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499)
* xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501)
* xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500)

Diff: https://github.com/xamarin/maccore/compare/8bb7dc6c38f40cab45fd916f082d794313b0855d..62e6757515dc46b3a99bfbc348932f25861f27bd
@rolfbjarne rolfbjarne mentioned this pull request Aug 26, 2021
rolfbjarne added a commit that referenced this pull request Aug 26, 2021
* Bump maccore.

New commits in xamarin/maccore:

* xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504)
* xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503)
* xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502)
* xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499)
* xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501)
* xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500)

Diff: https://github.com/xamarin/maccore/compare/8bb7dc6c38f40cab45fd916f082d794313b0855d..62e6757515dc46b3a99bfbc348932f25861f27bd

* Bump again.

New commits in xamarin/maccore:

* xamarin/maccore@3e591cbcb1 [provisioning-profiles] Add intermediate cert to the keychain. (#2506)

Diff: https://github.com/xamarin/maccore/compare/62e6757515dc46b3a99bfbc348932f25861f27bd..3e591cbcb15081d34a9512ca39d9df55c331bdbd
rolfbjarne added a commit that referenced this pull request Aug 26, 2021
New commits in xamarin/maccore:

* xamarin/maccore@3e591cbcb1 [provisioning-profiles] Add intermediate cert to the keychain. (#2506)
* xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504)
* xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503)
* xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502)
* xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499)
* xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501)
* xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500)
* xamarin/maccore@8bb7dc6c38 [docfixer] Add error checking to fix #xamarin/maccore@2479. (#2498)
* xamarin/maccore@93d0469437 [Xamarin.Hosting] Increase needed verbosity when logging loaded frameworks (#2497)

Diff: https://github.com/xamarin/maccore/compare/49c78df930c108297fcce4501432b451656190de..3e591cbcb15081d34a9512ca39d9df55c331bdbd
rolfbjarne added a commit that referenced this pull request Aug 27, 2021
New commits in xamarin/maccore:

* xamarin/maccore@3e591cbcb1 [provisioning-profiles] Add intermediate cert to the keychain. (#2506)
* xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504)
* xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503)
* xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502)
* xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499)
* xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501)
* xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500)
* xamarin/maccore@8bb7dc6c38 [docfixer] Add error checking to fix #xamarin/maccore@2479. (#2498)
* xamarin/maccore@93d0469437 [Xamarin.Hosting] Increase needed verbosity when logging loaded frameworks (#2497)

Diff: https://github.com/xamarin/maccore/compare/49c78df930c108297fcce4501432b451656190de..3e591cbcb15081d34a9512ca39d9df55c331bdbd

Co-authored-by: Alex Soto <alex@alexsoto.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants