[passkit] Update to beta 5 #2475
Conversation
| @@ -761,7 +762,6 @@ | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <EmbeddedResource Include="Security\openssl_crt.der"> | |||
| <LogicalName>monotouchtest.Security.openssl_crt.der</LogicalName> | |||
There was a problem hiding this comment.
I wonder why the IDE removed it, seems to happen for other PRs too
There was a problem hiding this comment.
Yep I got that too...
There was a problem hiding this comment.
@VincentDondain can you file a bug at the appropriate VSfM component ? thanks 😃
There was a problem hiding this comment.
@spouliot I would love to but I can't repro anymore. Might have an updated VS that fixed it.
There was a problem hiding this comment.
I think the IDE is technically right (it's removing the value because it's identical to the default value), but xharness currently needs the value when creating test variations (watchOS/tvOS projects).
| @@ -27,7 +27,7 @@ | |||
| <MtouchDebug>True</MtouchDebug> | |||
| <MtouchExtraArgs>-v -v -v -v</MtouchExtraArgs> | |||
| <AllowUnsafeBlocks>True</AllowUnsafeBlocks> | |||
| <MtouchArch>i386, x86_64</MtouchArch> | |||
| <MtouchArch>x86_64</MtouchArch> | |||
|
Build failure |
| [iOS (11,0)] | ||
| [Export ("paymentAuthorizationViewController:didAuthorizePayment:handler:")] | ||
| [EventArgs ("PKPaymentAuthorizationResult")] | ||
| void DidAuthorizePayment2 (PKPaymentAuthorizationViewController controller, PKPayment payment, Action<PKPaymentAuthorizationResult> completion); |
There was a problem hiding this comment.
Raaaaaah DidAuthorizePayment2... (:
I think you should XAMCORE-ify the name though (and the the other method).
There was a problem hiding this comment.
it's because of the events we added (we can't overload them) for that delegate
and XAMCORE might not help unless it's done when our minimum support is iOS11
it's not cute, but not unheard in .net, e.g. X509Certificate2 and it's friends :(
There was a problem hiding this comment.
and XAMCORE might not help unless it's done when our minimum support is iOS11
min support of iOS 11 or iOS 12?
Also I just don't understand what you mean here. If we decide to break the APIs again, like we did for classic / unified. Why does the minimum OS we support matters?
There was a problem hiding this comment.
It's not the same selector with a new managed signature, it's the same managed signature used by two different selectors (i.e. both methods need to exist).
|
tests failed because I inverted an |
|
Build failure |
1 similar comment
|
Build failure |
…able due to generics API)
…cios into xcode9-passkit
|
Build failure |
1 similar comment
|
Build failure |
jenkins failed to pull :( |
|
build |
|
Build failure |
2 similar comments
|
Build failure |
|
Build failure |
|
Build failure |
|
Build failure |
|
build |
|
Build failure |
|
issues with building the PR, will re-open the exact same one |
Identical to PR2475 who suffered from a fatal git issue :( [1] xamarin#2475
New commits in xamarin/maccore: * xamarin/maccore@7e6ffadb1f [Xamarin.Hosting] Only warn if we try to load a framework that doesn't exist. (xamarin#2473) * xamarin/maccore@cc42300ec4 [Xamarin.Hosting] Xcode 13 b3 doesn't have IBFoundation anymore, but it does have AssetCatalogFoundation, which we must load. (xamarin#2474) * xamarin/maccore@3e9801ee9a [Xamarin.Hosting] Improve error reporting when dlopen fails (xamarin#2475) Diff: https://github.com/xamarin/maccore/compare/c67d7af80d005d8a1a4321e4e5d4d148918d960b..7e6ffadb1fe1a8e1444485a9915b04dcc07ab95b
New commits in xamarin/maccore: * xamarin/maccore@7e6ffadb1f [Xamarin.Hosting] Only warn if we try to load a framework that doesn't exist. (#2473) * xamarin/maccore@cc42300ec4 [Xamarin.Hosting] Xcode 13 b3 doesn't have IBFoundation anymore, but it does have AssetCatalogFoundation, which we must load. (#2474) * xamarin/maccore@3e9801ee9a [Xamarin.Hosting] Improve error reporting when dlopen fails (#2475) Diff: https://github.com/xamarin/maccore/compare/c67d7af80d005d8a1a4321e4e5d4d148918d960b..7e6ffadb1fe1a8e1444485a9915b04dcc07ab95b
No description provided.