Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppKit b3 changes #2347

Merged
merged 2 commits into from
Jul 20, 2017
Merged

AppKit b3 changes #2347

merged 2 commits into from
Jul 20, 2017

Conversation

chamons
Copy link
Contributor

@chamons chamons commented Jul 19, 2017

No description provided.

rolfbjarne
rolfbjarne requested changes Jul 19, 2017
View reviewed changes
src/appkit.cs Outdated

[Mac (10, 13)]
[Field ("NSImageNameTouchBarRemoveTemplate")]
TouchBarRemoveTemplate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: missing trailing comma.

src/appkit.cs Outdated
@@ -11323,6 +11331,14 @@ partial interface NSPasteboard // NSPasteboard does _not_ implement NSPasteboard
[Field ("NSPasteboardTypeFindPanelSearchOptions")]
NSString NSPasteboardTypeFindPanelSearchOptions { get; }

[Mac (10, 13)]
[Field ("NSPasteboardTypeURL")]
NSString NSPasteboardTypeURL { get; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Url, not URL

src/appkit.cs Outdated

[Mac (10, 13)]
[Field ("NSPasteboardTypeFileURL")]
NSString NSPasteboardTypeFileURL { get; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Url, not URL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really need to burn Url in my head, it always "looks wrong".

@monojenkins
Copy link
Collaborator

Build failure

@monojenkins
Copy link
Collaborator

Build success

@chamons chamons merged commit dd2409a into xamarin:xcode9 Jul 20, 2017
@chamons chamons deleted the xcode9-appkit-b3 branch July 20, 2017 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentDondain VincentDondain VincentDondain approved these changes

@spouliot spouliot spouliot approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chamons @monojenkins @dalexsoto @rolfbjarne @spouliot @VincentDondain @dnfclas