[messages] Update for Xcode 9 beta 1 & 3 #2332
Conversation
src/messages.cs
Outdated
| [iOS (11,0)] | ||
| [Abstract] | ||
| [Export ("contentSizeThatFits:")] | ||
| CGSize ContentSizeThatFits (CGSize size); |
There was a problem hiding this comment.
You need a verb to begin the method name so maybe GetContentSizeThatFits
| [iOS (11,0)] | ||
| [Export ("sendMessage:completionHandler:")] | ||
| [Async] | ||
| void SendMessage (MSMessage message, [NullAllowed] Action<NSError> completionHandler); |
There was a problem hiding this comment.
I think you can just name it Send
There was a problem hiding this comment.
This match the existing Insert* API so we better use the longer names.
That's also a case that could bite back, e.g. sendFoo: and sendBar: both accepting an NSString with a different meaning (but the C# signature would be identical). It's easier to add overloads when the first parameters are identical.
| [iOS (11,0)] | ||
| [Export ("sendSticker:completionHandler:")] | ||
| [Async] | ||
| void SendSticker (MSSticker sticker, [NullAllowed] Action<NSError> completionHandler); |
There was a problem hiding this comment.
I think you can just name it Send
| [iOS (11,0)] | ||
| [Export ("sendText:completionHandler:")] | ||
| [Async] | ||
| void SendText (string text, [NullAllowed] Action<NSError> completionHandler); |
There was a problem hiding this comment.
I think you can just name it Send
| [iOS (11,0)] | ||
| [Export ("sendAttachment:withAlternateFilename:completionHandler:")] | ||
| [Async] | ||
| void SendAttachment (NSUrl url, [NullAllowed] string filename, [NullAllowed] Action<NSError> completionHandler); |
There was a problem hiding this comment.
I think you can just name it Send
|
Build failure |
| [iOS (11,0)] | ||
| [Export ("sendMessage:completionHandler:")] | ||
| [Async] | ||
| void SendMessage (MSMessage message, [NullAllowed] Action<NSError> completionHandler); |
There was a problem hiding this comment.
This match the existing Insert* API so we better use the longer names.
That's also a case that could bite back, e.g. sendFoo: and sendBar: both accepting an NSString with a different meaning (but the C# signature would be identical). It's easier to add overloads when the first parameters are identical.
| [iOS (11,0)] | ||
| [Export ("sendSticker:completionHandler:")] | ||
| [Async] | ||
| void SendSticker (MSSticker sticker, [NullAllowed] Action<NSError> completionHandler); |
| [iOS (11,0)] | ||
| [Export ("sendText:completionHandler:")] | ||
| [Async] | ||
| void SendText (string text, [NullAllowed] Action<NSError> completionHandler); |
| [iOS (11,0)] | ||
| [Export ("sendAttachment:withAlternateFilename:completionHandler:")] | ||
| [Async] | ||
| void SendAttachment (NSUrl url, [NullAllowed] string filename, [NullAllowed] Action<NSError> completionHandler); |
| } | ||
|
|
||
| [iOS (10,0)] | ||
| [BaseType (typeof(UIViewController))] | ||
| interface MSMessagesAppViewController | ||
| interface MSMessagesAppViewController : MSMessagesAppTranscriptPresentation |
There was a problem hiding this comment.
Deriving from the protocol will inline all the protocol members, which IMO is not what you want to do here.
Derive from IMSMessagesAppTranscriptPresentation instead (you'll have to add an empty interface IMSMessagesAppTranscriptPresentation {} declaration first). That will tell the generator that the class implements the protocol (and generate in managed code implement the corresponding protocol interface), without inlining the protocol members.
There was a problem hiding this comment.
Ignore this comment, I got confused with something else.
This is 👍
|
Build success |
Commits: * Insert keychain into search list without overwriting other keychains xamarin/maccore@2438100 * Fix working in comment xamarin/maccore@2438100 * Insert login keychain without overwriting other keychains in the search xamarin/maccore@7e6beed * Merge pull request xamarin#2332 from xamarin/yaml-pipeline-device-tests xamarin/maccore@7e6beed * Avoid adding duplicate keychains to keychain list (xamarin#2333) xamarin/maccore@7e6beed * [Governance] Fix some small polycheck issues. xamarin/maccore@51bea51 * [Governance] Fix some small polycheck issues. xamarin/maccore@f490737 Full diff: https://github.com/xamarin/maccore/compare/6a86f16e0f8bf5cad707eb9bb145a40596a7f438..f490737c8e3a7ecedb6005bfc8cc9792fe046931
Commits: * Insert keychain into search list without overwriting other keychains xamarin/maccore@2438100 * Fix working in comment xamarin/maccore@2438100 * Insert login keychain without overwriting other keychains in the search xamarin/maccore@7e6beed * Merge pull request #2332 from xamarin/yaml-pipeline-device-tests xamarin/maccore@7e6beed * Avoid adding duplicate keychains to keychain list (#2333) xamarin/maccore@7e6beed * [Governance] Fix some small polycheck issues. xamarin/maccore@51bea51 * [Governance] Fix some small polycheck issues. xamarin/maccore@f490737 Full diff: https://github.com/xamarin/maccore/compare/6a86f16e0f8bf5cad707eb9bb145a40596a7f438..f490737c8e3a7ecedb6005bfc8cc9792fe046931
No description provided.