bump max visual studio version to latest alpha #2171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
…eption while throwing an exception during a build.
|
You can see more about the issue that allow the bug to be seen here. https://bugzilla.xamarin.com/show_bug.cgi?id=57124 |
zippo227
changed the title
spouliot
suggested changes
Jun 3, 2017
zippo227
changed the title
|
@spouliot I understand and changed as requested |
|
I think this got too bloated and it is not recognizing my rebase. I've made a new, cleaner pull request. #2173 |
dalexsoto
added a commit
that referenced
this pull request
Apr 2, 2020
New commits in xamarin/maccore: * xamarin/maccore@fdeec0f4cc Update external-deps.csx (#2191) * xamarin/maccore@f473e45166 [Localization] Rework mlaunch (#2171) Diff: https://github.com/xamarin/maccore/compare/5dbf6f4c5fdfd8fa24e569f89a7c79f12d99e9e5..fdeec0f4ccdfdb9111d594b7f7189cd58e06216d
dalexsoto
added a commit
that referenced
this pull request
Apr 2, 2020
New commits in xamarin/maccore: * xamarin/maccore@fdeec0f4cc Update external-deps.csx (#2191) * xamarin/maccore@f473e45166 [Localization] Rework mlaunch (#2171) Diff: https://github.com/xamarin/maccore/compare/5dbf6f4c5fdfd8fa24e569f89a7c79f12d99e9e5..fdeec0f4ccdfdb9111d594b7f7189cd58e06216d
dalexsoto
pushed a commit
to dalexsoto/xamarin-macios
that referenced
this pull request
Apr 6, 2020
The name of the dll changed, ergo the prefix changed. New commits in xamarin/maccore: * xamarin/maccore@a14f74b40a Revert "[Localization] Rework mlaunch (xamarin#2171)" (xamarin#2194) * xamarin/maccore@9939a3812d [mlaunch] Accept the latest C# language version in projects (xamarin#2193) Diff: https://github.com/xamarin/maccore/compare/fdeec0f4ccdfdb9111d594b7f7189cd58e06216d..a14f74b40ac5ed01a9a384d758b50e5a7c563569
dalexsoto
added a commit
to dalexsoto/xamarin-macios
that referenced
this pull request
Apr 6, 2020
New commits in xamarin/maccore: * xamarin/maccore@a14f74b40a Revert "[Localization] Rework mlaunch (xamarin#2171)" (xamarin#2194) * xamarin/maccore@9939a3812d [mlaunch] Accept the latest C# language version in projects (xamarin#2193) Diff: https://github.com/xamarin/maccore/compare/fdeec0f4ccdfdb9111d594b7f7189cd58e06216d..a14f74b40ac5ed01a9a384d758b50e5a7c563569
dalexsoto
added a commit
that referenced
this pull request
Apr 6, 2020
New commits in xamarin/maccore: * xamarin/maccore@a14f74b40a Revert "[Localization] Rework mlaunch (#2171)" (#2194) * xamarin/maccore@9939a3812d [mlaunch] Accept the latest C# language version in projects (#2193) Diff: https://github.com/xamarin/maccore/compare/fdeec0f4ccdfdb9111d594b7f7189cd58e06216d..a14f74b40ac5ed01a9a384d758b50e5a7c563569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I increased the allowed visual studio version, and I added a fix that also prevents a null exception from attempting to be read during build error generation.