-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xcode15.4] Update bindings to Xcode 15.4 #20846
Conversation
It doesn't work because Xcode doesn't contain the information required to compute the old-style url.
Apple removed the AssetsLibrary framework from iOS in Xcode 15.3.
It doesn't look like i386 works anymore.
There's no need for a version check, since what's important is which version of Xcode was used to compile the app.
…ev/alex/xcode15.4-bump
src/uikit.cs
Outdated
@@ -331,7 +331,13 @@ interface NSAttributedStringAttachmentConveniences { | |||
[DisableDefaultCtor] | |||
[Abstract] // abstract class that should not be used directly | |||
[BaseType (typeof (NSObject))] | |||
interface UIFeedbackGenerator { | |||
interface UIFeedbackGenerator : UIInteraction { | |||
// intancetype -> UIFeedbackGenerator, inlined as subclasses should return the same type as the instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// intancetype -> UIFeedbackGenerator, inlined as subclasses should return the same type as the instance | |
// instancetype -> UIFeedbackGenerator, inlined as subclasses should return the same type as the instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you can do it this way, you have to duplicate the binding in each subclass.
This method will always create a UIFeedbackGenerator
, even when called from a subclass, and the fact that we cast the return value to the expected managed type doesn't actually make the returned instance of the corresponding native type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, this should be fixed now
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 168 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Continued in #20846. |
No description provided.