Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Adjust MessageHandlerTest.GHIssue16339 slightly. #20264

Merged
merged 1 commit into from
Mar 7, 2024

Commits on Mar 6, 2024

  1. [tests] Adjust MessageHandlerTest.GHIssue16339 slightly.

    We've recently had a few test failures like this:
    
        MonoTests.System.Net.Http.MessageHandlerTest.GHIssue16339
         	[FAIL] GHIssue16339() :   IsSuccessStatusCode #1
           Expected: True
           But was:  False
    
    which doesn't provide much info into what went wrong.
    
    It turns out this particular assert for IsSuccessStatusCode is redundant,
    because we assert on the exact StatusCode a bit later, and if that assert
    fails, we'll know a bit more.
    
    So just remove this redundant assert for IsSuccessStatusCode.
    rolfbjarne committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    27627a5 View commit details
    Browse the repository at this point in the history