Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Allow a little bit of leeway when testing floating point numbers in SKTransformNodeTest. #18157

Merged
merged 1 commit into from
Apr 27, 2023
Merged

[tests] Allow a little bit of leeway when testing floating point numbers in SKTransformNodeTest. #18157

merged 1 commit into from
Apr 27, 2023

Conversation

rolfbjarne
Copy link
Member

Fixes this test failure:

MonoTouchFixtures.SpriteKit.SKTransformNodeTest
    [FAIL] EulerAngles :   #x1
        Expected: -2.14159298f
        But was:  -2.14159274f

@rolfbjarne
[tests] Allow a little bit of leeway when testing floating point numb…
05c4a37 
…ers in SKTransformNodeTest.

Fixes this test failure:

    MonoTouchFixtures.SpriteKit.SKTransformNodeTest
        [FAIL] EulerAngles :   #x1
            Expected: -2.14159298f
            But was:  -2.14159274f
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 05c4a37c4143dcfaa4f1c5478c74a80f8d032cc7 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1030.Ventura
Hash: 05c4a37c4143dcfaa4f1c5478c74a80f8d032cc7 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 05c4a37c4143dcfaa4f1c5478c74a80f8d032cc7 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: [PR build]

@rolfbjarne rolfbjarne mentioned this pull request Apr 27, 2023
Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 05c4a37c4143dcfaa4f1c5478c74a80f8d032cc7 [PR build]

@rolfbjarne
Copy link
Member Author

Test failure is unrelated (#18159).

@rolfbjarne rolfbjarne merged commit bdf25df into xamarin:main Apr 27, 2023
@rolfbjarne rolfbjarne deleted the tests-better-fp-comparison-sktransformnodetest branch April 27, 2023 15:55
@rolfbjarne
Copy link
Member Author

/sudo backport release/7.0.2xx-xcode14.3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.2xx-xcode14.3 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7694142 for more details.

@rolfbjarne
Copy link
Member Author

/sudo backport release/7.0.2xx-xcode14.2

@rolfbjarne
Copy link
Member Author

/sudo backport release/7.0.3xx

@rolfbjarne
Copy link
Member Author

/sudo backport release/6.0.4xx-xcode14.2

@rolfbjarne
Copy link
Member Author

/sudo backport release/6.0.4xx-xcode14.3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.3xx Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.2xx-xcode14.2 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.4xx-xcode14.2 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.4xx-xcode14.3 Created! The magic is happening here

This was referenced Apr 27, 2023
Merged
Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7694192 for more details.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7694190 for more details.

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7694187 for more details.

@rolfbjarne
Copy link
Member Author

/sudo backport release/7.0.2xx

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.2xx Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7694251 for more details.

rolfbjarne added a commit that referenced this pull request Apr 28, 2023
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/6.0.4xx-xcode14.3] [tests] Allow a little bit of leeway when…
1e29b9a 
… testing floating point numbers in SKTransformNodeTest. (#18168)

Fixes this test failure:

    MonoTouchFixtures.SpriteKit.SKTransformNodeTest
        [FAIL] EulerAngles :   #x1
            Expected: -2.14159298f
            But was:  -2.14159274f


Backport of #18157

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
rolfbjarne added a commit that referenced this pull request Apr 28, 2023
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/6.0.4xx-xcode14.2] [tests] Allow a little bit of leeway when…
96308dd 
… testing floating point numbers in SKTransformNodeTest. (#18169)

Fixes this test failure:

    MonoTouchFixtures.SpriteKit.SKTransformNodeTest
        [FAIL] EulerAngles :   #x1
            Expected: -2.14159298f
            But was:  -2.14159274f


Backport of #18157

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
rolfbjarne added a commit that referenced this pull request Apr 28, 2023
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/7.0.2xx-xcode14.3] [tests] Allow a little bit of leeway when…
2895111 
… testing floating point numbers in SKTransformNodeTest. (#18165)

Fixes this test failure:

    MonoTouchFixtures.SpriteKit.SKTransformNodeTest
        [FAIL] EulerAngles :   #x1
            Expected: -2.14159298f
            But was:  -2.14159274f


Backport of #18157

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
rolfbjarne added a commit that referenced this pull request Apr 28, 2023
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/7.0.3xx] [tests] Allow a little bit of leeway when testing f…
d1a73d1 
…loating point numbers in SKTransformNodeTest. (#18170)

Fixes this test failure:

    MonoTouchFixtures.SpriteKit.SKTransformNodeTest
        [FAIL] EulerAngles :   #x1
            Expected: -2.14159298f
            But was:  -2.14159274f


Backport of #18157

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
rolfbjarne added a commit that referenced this pull request Apr 28, 2023
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/7.0.2xx] [tests] Allow a little bit of leeway when testing f…
bfea84b 
…loating point numbers in SKTransformNodeTest. (#18173)

Fixes this test failure:

    MonoTouchFixtures.SpriteKit.SKTransformNodeTest
        [FAIL] EulerAngles :   #x1
            Expected: -2.14159298f
            But was:  -2.14159274f


Backport of #18157

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@rolfbjarne
Copy link
Member Author

/sudo backport release/8.0.1xx-preview4

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/8.0.1xx-preview4 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7698555 for more details.

rolfbjarne added a commit that referenced this pull request May 3, 2023
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/8.0.1xx-preview4] [tests] Allow a little bit of leeway when …
a5e4d57 
…testing floating point numbers in SKTransformNodeTest. (#18180)

Fixes this test failure:

    MonoTouchFixtures.SpriteKit.SKTransformNodeTest
        [FAIL] EulerAngles :   #x1
            Expected: -2.14159298f
            But was:  -2.14159274f


Backport of #18157

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@rolfbjarne
Copy link
Member Author

/sudo backport xcode14.3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch xcode14.3 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8317481 for more details.

rolfbjarne pushed a commit that referenced this pull request Aug 29, 2023
@vs-mobiletools-engineering-service2
[xcode14.3] [tests] Allow a little bit of leeway when testing floatin…
36a6c18 
…g point numbers in SKTransformNodeTest. (#18842)

Fixes this test failure:

    MonoTouchFixtures.SpriteKit.SKTransformNodeTest
        [FAIL] EulerAngles :   #x1
            Expected: -2.14159298f
            But was:  -2.14159274f


Backport of #18157

Fixes xamarin/maccore#2701.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haritha-mohan haritha-mohan haritha-mohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @haritha-mohan