[Avfoundation] Add support for xcode14.1 #16408

mandel-macaque · 2022-10-21T16:13:00Z

No description provided.

github-actions · 2022-10-21T16:16:49Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

tj-devel709 · 2022-10-21T21:56:39Z

src/CoreMidi/MidiStructs.cs

+
+#if NET
+		[SupportedOSPlatform ("ios14.0")]
+		[SupportedOSPlatform ("maccatalyst")]


No need, macCatalyst min version is 14.0

src/CoreMidi/MidiStructs.cs

src/avfoundation.cs

dalexsoto · 2022-10-21T22:06:37Z

src/avfoundation.cs

@@ -8692,6 +8970,25 @@ interface AVMutableVideoComposition {
 		[Export ("sourceSampleDataTrackIDs", ArgumentSemantic.Copy)]
 		[BindAs (typeof (int[]))]
 		NSNumber[] SourceSampleDataTrackIds { get; set; }
+
+		[Async]


I am not sure we want Async here, is the completion handler really something that needs to be waited for in this context? Since it is a Create method, same for the following ones

dalexsoto · 2022-10-21T22:07:54Z

src/avfoundation.cs

+
+		[NoWatch, NoTV, MacCatalyst (16, 0), Mac (13, 0), iOS (16, 0)]
+		[Export ("supportedMaxPhotoDimensions")]
+		NSValue[] SupportedMaxPhotoDimensions { get; }


BindAs maybe? Any ideas on the wrapped types? Same for the one below

tj-devel709

The mac attribute mostly

tj-devel709 · 2022-10-21T22:03:36Z

src/avfoundation.cs

+	interface AVMutableMovie_SynchronousAssetInterface
+	{
+		[Export ("metadataForFormat:")]
+		AVMetadataItem[] GetMetadataForFormat (string format);


Suggested change

AVMetadataItem[] GetMetadataForFormat (string format);

AVMetadataItem[] GetMetadata (string format);

src/avfoundation.cs

src/AVFoundation/AVSpeechUtterance.cs

rolfbjarne · 2022-10-24T09:05:23Z

src/CoreMidi/MidiStructs.cs

+#if !COREBUILD
+		public MidiProtocolId protocol;
+#endif


There are a couple of issues here:

Structs must have the same size between COREBUILD and !COREBUILD.

Public API must not start with a lower-cased letter.

It's often best to have private fields and public property accessors for structs, because it makes things easier if Apple changes their structs, and also if we need to adjust due to marshalling reasons (which is even more important for this struct, since it contains a variable-length array).

So something like this instead.

int protocol; ... #if !COREBUILD public MidiProtocolId Protocol { get => (MidiProtocolId) protocol; set => protocol = (int) value; } #endif

rolfbjarne · 2022-10-24T09:10:08Z

src/CoreMidi/MidiStructs.cs

+	[iOS (14,0), Mac (11,0), Watch (8,0), TV (14,0)]
+#endif
+	[StructLayout (LayoutKind.Sequential)]
+	public struct MidiEventPacket


Same as for previous struct: private fields + public accessors.

src/avfoundation.cs

rolfbjarne · 2022-10-24T09:13:28Z

src/avfoundation.cs

+#if MONOMAC
+		[TV (16,0), NoWatch, Mac (13,0), iOS (16,0), MacCatalyst (16,0)]
+		[Export ("sendMIDIEventList:")]
+		void SendMidiEventList (MidiEventList eventList);


Needs manual bindings because MidiEventList is a variable-length struct.

rolfbjarne · 2022-10-24T09:15:46Z

src/avfoundation.cs

+		CMTime GetSamplePresentationTime (CMTime trackTime);
+
+		[Export ("metadataForFormat:")]
+		AVMetadataItem [] GetMetadataForFormat (NSString format);


Suggested change

AVMetadataItem [] GetMetadataForFormat (NSString format);

AVMetadataItem [] GetMetadata (NSString format);

rolfbjarne · 2022-10-24T09:16:59Z

src/avfoundation.cs

+		AVMetadataItem [] GetMetadata (AVMetadataFormat format);
+
+		[Export ("associatedTracksOfType:")]
+		AVAssetTrack [] GetAssociatedTracks (NSString avAssetTrackTrackAssociationType);


Look like this can be strongly typed to AVAssetTrackTrackAssociation somehow.

rolfbjarne · 2022-10-24T09:17:12Z

src/avfoundation.cs

+		AVMetadataItem [] GetMetadata (AVMetadataFormat format);
+
+		[Export ("associatedTracksOfType:")]
+		AVAssetTrack [] GetAssociatedTracks (NSString avAssetTrackTrackAssociationType);


Same: strongly typed to AVAssetTrackTrackAssociation

rolfbjarne · 2022-10-24T09:17:21Z

src/avfoundation.cs

+		CMTime GetSamplePresentationTime (CMTime trackTime);
+
+		[Export ("metadataForFormat:")]
+		AVMetadataItem[] GetMetadataForFormat (string format);


Suggested change

AVMetadataItem[] GetMetadataForFormat (string format);

AVMetadataItem[] GetMetadata (string format);

src/avfoundation.cs

Co-authored-by: Alex Soto <alex@alexsoto.me> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

stephen-hawley · 2022-10-25T15:19:34Z

src/avfoundation.cs

+	interface AVComposition_SynchronousAssetInterface
+	{
+		[Export ("metadataForFormat:")]
+		AVMetadataItem[] GetMetadataForFormat (NSString format);


Same - change to `GetMetadata (NSString format);

stephen-hawley · 2022-10-25T15:20:13Z

src/avfoundation.cs

+		[Async]
+		[Watch (9,0), TV (16,0), Mac (13,0), iOS (16,0), MacCatalyst (16,0)]
+		[Export ("insertTimeRange:ofAsset:atTime:completionHandler:")]
+		void InsertTimeRange (CMTimeRange timeRange, AVAsset asset, CMTime startTime, Action<NSError> completionHandler);


Should this be Insert instead of InsertTimeRange?

stephen-hawley · 2022-10-25T15:21:26Z

src/avfoundation.cs

+		AVTimedMetadataGroup[] GetChapterMetadataGroups (NSLocale locale, [NullAllowed] string[] commonKeys);
+
+		[Export ("chapterMetadataGroupsBestMatchingPreferredLanguages:")]
+		AVTimedMetadataGroup[] GetChapterMetadataGroupsBestMatchingPreferredLanguages (string[] preferredLanguages);


Should this be GetChapterMetadataGroupsBestMatching?

stephen-hawley · 2022-10-25T15:23:38Z

src/avfoundation.cs

+
+		[TV (16, 0), Mac (13, 0), iOS (16, 0), MacCatalyst (16,0)]
+		[Field ("AVVideoTransferFunction_Linear")]
+		NSString AVVideoTransferFunction_Linear { get; }


Do we want the underscore?

stephen-hawley · 2022-10-25T15:25:55Z

src/avfoundation.cs

+		NativeHandle Constructor (uint channel, AVMidiControlChangeMessageType messageType, uint value);
+
+		[Export ("messageType")]
+		AVMidiControlChangeMessageType MessageType { get; }


Why MessageType here and Type in AVMidiMetaEvent?

vs-mobiletools-engineering-service2 · 2022-11-02T18:48:09Z

❗ API diff for current PR / commit (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
watchOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
watchOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 1015d613e07f5d7986174668ede37575e1235647 [PR build]

vs-mobiletools-engineering-service2 · 2022-11-02T18:56:22Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1167.Monterey'
Hash: 1015d613e07f5d7986174668ede37575e1235647 [PR build]

vs-mobiletools-engineering-service2 · 2022-11-02T19:03:17Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

monotouch-test

Pipeline on Agent
Hash: 1015d613e07f5d7986174668ede37575e1235647 [PR build]

vs-mobiletools-engineering-service2 · 2022-11-02T21:52:19Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 8 tests failed, 215 tests passed.

Failures

❌ bcl tests

4 tests failed, 65 tests passed.

[NUnit] Mono BCL tests group 1/tvOS - simulator/Debug: LaunchTimedOut
[NUnit] Mono BCL tests group 2/tvOS - simulator/Debug: LaunchTimedOut
[xUnit] Mono BCL tests group 3/tvOS - simulator/Debug: LaunchTimedOut
[xUnit] Mono SystemXunit/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

❌ cecil tests

1 tests failed, 0 tests passed.

Cecil-based tests/NUnit: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ xtro tests

2 tests failed, 0 tests passed.

Xtro/Legacy Xamarin: BuildFailure
Xtro/.NET: BuildFailure

Html Report (VSDrops) Download

Successes

✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

mandel-macaque added 4 commits October 17, 2022 10:43

[AVfoundation] Add support for xcode 14.1 beta 3.

208998e

[AVFoundation] Add support for xcode 14.1 beta 3.

ccd8bc6

Merge branch 'xcode14.1' into avfoundation-xcode14.1

d98031a

[AVFoundation] Add support for xcode 14.1

079bbeb

mandel-macaque added the notes-mention Deserves a mention in release notes label Oct 21, 2022

mandel-macaque requested review from rolfbjarne and dalexsoto as code owners October 21, 2022 16:13

mandel-macaque changed the title ~~Avfoundation xcode14.1~~ [Avfoundation] Add support for xcode14.1 Oct 21, 2022

Auto-format source code

c393832

tj-devel709 reviewed Oct 21, 2022

View reviewed changes

mandel-macaque commented Oct 21, 2022

View reviewed changes

src/CoreMidi/MidiStructs.cs Outdated Show resolved Hide resolved

mandel-macaque commented Oct 21, 2022

View reviewed changes

src/CoreMidi/MidiStructs.cs Outdated Show resolved Hide resolved

mandel-macaque commented Oct 21, 2022

View reviewed changes

src/CoreMidi/MidiStructs.cs Outdated Show resolved Hide resolved

mandel-macaque commented Oct 21, 2022

View reviewed changes

src/CoreMidi/MidiStructs.cs Outdated Show resolved Hide resolved

Apply suggestions from code review

929b3e8

dalexsoto requested changes Oct 21, 2022

View reviewed changes

tj-devel709 requested changes Oct 21, 2022

View reviewed changes

rolfbjarne requested changes Oct 24, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque and others added 2 commits October 24, 2022 16:03

Apply suggestions from code review

88f39f7

Co-authored-by: Alex Soto <alex@alexsoto.me> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Update src/AVFoundation/AVSpeechUtterance.cs

fe53a3e

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

This comment has been minimized.

Sign in to view

stephen-hawley requested changes Oct 25, 2022

View reviewed changes

Merge branch 'xcode14.1' into avfoundation-xcode14.1

1015d61

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Avfoundation] Add support for xcode14.1 #16408

[Avfoundation] Add support for xcode14.1 #16408

mandel-macaque commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

tj-devel709 Oct 21, 2022

mandel-macaque Oct 21, 2022

dalexsoto Oct 21, 2022

dalexsoto Oct 21, 2022

tj-devel709 left a comment

tj-devel709 Oct 21, 2022

rolfbjarne Oct 24, 2022

rolfbjarne Oct 24, 2022

rolfbjarne Oct 24, 2022

rolfbjarne Oct 24, 2022

rolfbjarne Oct 24, 2022

rolfbjarne Oct 24, 2022

rolfbjarne Oct 24, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

stephen-hawley Oct 25, 2022

stephen-hawley Oct 25, 2022

stephen-hawley Oct 25, 2022

stephen-hawley Oct 25, 2022

stephen-hawley Oct 25, 2022

vs-mobiletools-engineering-service2 commented Nov 2, 2022

vs-mobiletools-engineering-service2 commented Nov 2, 2022

vs-mobiletools-engineering-service2 commented Nov 2, 2022

vs-mobiletools-engineering-service2 commented Nov 2, 2022

	AVMetadataItem[] GetMetadataForFormat (string format);
	AVMetadataItem[] GetMetadata (string format);

	AVMetadataItem [] GetMetadataForFormat (NSString format);
	AVMetadataItem [] GetMetadata (NSString format);

[Avfoundation] Add support for xcode14.1 #16408

Are you sure you want to change the base?

[Avfoundation] Add support for xcode14.1 #16408

Conversation

mandel-macaque commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

⚠️ Your code has been reformatted. ⚠️

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tj-devel709 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Nov 2, 2022

❗ API diff for current PR / commit (Breaking changes)

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Nov 2, 2022

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Nov 2, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

vs-mobiletools-engineering-service2 commented Nov 2, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ bcl tests

❌ cecil tests

❌ dotnettests tests

❌ xtro tests

Successes