Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IdentityLookup] Updates for Xcode14 beta1 #15740

Merged
merged 4 commits into from
Aug 25, 2022
Merged

[IdentityLookup] Updates for Xcode14 beta1 #15740

merged 4 commits into from
Aug 25, 2022

Conversation

tj-devel709
Copy link
Contributor

No description provided.

@tj-devel709 tj-devel709 added the notes-mention Deserves a mention in release notes label Aug 23, 2022
@tj-devel709 tj-devel709 added this to the xcode14 milestone Aug 23, 2022
@tj-devel709 tj-devel709 requested a review from dalexsoto as a code owner August 23, 2022 18:28
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
dalexsoto
dalexsoto requested changes Aug 23, 2022
View reviewed changes
src/identitylookup.cs Outdated

[NoWatch, NoTV, NoMac, MacCatalyst (16,0), iOS (16,0)]
[NullAllowed, Export ("receiverISOCountryCode")]
string ReceiverISOCountryCode { get; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
string ReceiverISOCountryCode { get; }
string ReceiverIsoCountryCode { get; }

src/identitylookup.cs Outdated
[Protocol]
interface ILMessageFilterCapabilitiesQueryHandling
{
[Async]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Async]

No Async on protocols

src/identitylookup.cs Outdated
Comment on lines 260 to 264
[Export ("transactionalSubActions", ArgumentSemantic.Copy)]
NSNumber[] TransactionalSubActions { get; set; }

[Export ("promotionalSubActions", ArgumentSemantic.Copy)]
NSNumber[] PromotionalSubActions { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these properties according to documentation are ILMessageFilterSubAction []

Suggested change
[Export ("transactionalSubActions", ArgumentSemantic.Copy)]
NSNumber[] TransactionalSubActions { get; set; }
[Export ("promotionalSubActions", ArgumentSemantic.Copy)]
NSNumber[] PromotionalSubActions { get; set; }
[BindAs (typeof (ILMessageFilterSubAction []))]
[Export ("transactionalSubActions", ArgumentSemantic.Copy)]
NSNumber[] TransactionalSubActions { get; set; }
[BindAs (typeof (ILMessageFilterSubAction []))]
[Export ("promotionalSubActions", ArgumentSemantic.Copy)]
NSNumber[] PromotionalSubActions { get; set; }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch!

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❗ API diff for current PR / commit (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • tvOS: (empty diff detected)
  • MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 20cbe9fe85bb301c0c5d83e29489e2df48795e96 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 20cbe9fe85bb301c0c5d83e29489e2df48795e96 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1170.Monterey'
Hash: 20cbe9fe85bb301c0c5d83e29489e2df48795e96 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 20cbe9fe85bb301c0c5d83e29489e2df48795e96 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 4 tests failed, 224 tests passed.

Failures

❌ bcl tests

2 tests failed, 67 tests passed.
  • mscorlib Part 3/tvOS - simulator/Debug: Crashed
  • [xUnit] Mono SystemXunit/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

❌ framework tests

1 tests failed, 7 tests passed.
  • framework-test/watchOS 32-bits - simulator/Debug: TimedOut

Html Report (VSDrops) Download

❌ introspection tests

1 tests failed, 12 tests passed.
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@tj-devel709 tj-devel709 merged commit fb59f9d into xamarin:xcode14 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SotoiGhost SotoiGhost SotoiGhost approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
notes-mention Deserves a mention in release notes
Projects
None yet
Milestone
xcode14
Development

Successfully merging this pull request may close these issues.
5 participants
@tj-devel709 @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @SotoiGhost