-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UniformTypeIdentifiers] Add support for Xcode 14 beta 1, 2 & 3 #15550
[UniformTypeIdentifiers] Add support for Xcode 14 beta 1, 2 & 3 #15550
Conversation
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 3 tests failed, 225 tests passed. Failures❌ cecil tests
Html Report (VSDrops) Download ❌ introspection tests
Html Report (VSDrops) Download ❌ xtro tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
||
[Watch (9,0), TV (16,0), Mac (13,0), iOS (16,0), MacCatalyst (16,0)] | ||
[Export ("loadFileRepresentationForContentType:openInPlace:completionHandler:")] | ||
NSProgress LoadFileRepresentation (UTType contentType, bool openInPlace, ItemProviderDataCompletionHandler completionHandler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
completionHandler
has a wrong signature. You could reuse LoadInPlaceFileRepresentationHandler
but it has one different param name:
NSProgress LoadFileRepresentation (UTType contentType, bool openInPlace, ItemProviderDataCompletionHandler completionHandler); | |
NSProgress LoadFileRepresentation (UTType contentType, bool openInPlace, LoadInPlaceFileRepresentationHandler completionHandler); |
or create a new handler with right param names:
NSProgress LoadFileRepresentation (UTType contentType, bool openInPlace, ItemProviderDataCompletionHandler completionHandler); | |
NSProgress LoadFileRepresentation (UTType contentType, bool openInPlace, LoadFileRepresentationHandler completionHandler); | |
[Watch (9,0), TV (16,0), Mac (13,0), iOS (16,0), MacCatalyst (16,0)] | |
delegate void LoadFileRepresentationHandler (NSUrl fileUrl, bool openInPlace, NSError error); |
hmm... it seems I didn't refresh the page, didn't notice that this was merged. I'll create a new PR to fix this. |
No description provided.