[AppKit] Update Xcode 13.0 bindings for betas 1,2,3,4,5 #12936

rachelkang · 2021-10-05T16:00:41Z

No description provided.

rachelkang · 2021-10-05T16:02:06Z

src/appkit.cs

@@ -13069,6 +13143,30 @@ partial interface NSScreen {
 		string LocalizedName { get; }
 	}

+	[NoMacCatalyst]
+	partial interface NSScreen


Was unsure about what to do about this interface structure - there are a couple other partial interfaces with the same name, in the same file here. Not sure why they're all separated, but sharpie does the same, and diffs suggest the interface is new for some reason. So, I just did what the diffs/sharpie seem to indicate.

But I was wondering - why is it like that? Can't I just add these new properties to the partial interface above?

I don't know why sharpie does that, but you can just add it to any existing partial interfaces (at the very least it makes it less confusing for the next person).

sounds good, thanks!

rolfbjarne

This looks great! I mostly just had a few comments about naming.

rolfbjarne · 2021-10-05T16:19:55Z

src/appkit.cs

+		[Mac (12,0)]
+		[IgnoredInDelegate]
+		[Export ("applicationSupportsSecureRestorableState:")]
+		bool ApplicationSupportsSecureRestorableState (NSApplication application);


The 'application' suffix is often emitted from the managed name in this case, because it's somewhat redundant (look at the other methods in this class, they mostly do the same thing) - in the UIApplicationDelegate class the logic is about UIApplication, which means that spelling out 'Application' all the time feels a bit unnecessary:

Suggested change

bool ApplicationSupportsSecureRestorableState (NSApplication application);

bool SupportsSecureRestorableState (NSApplication application);

rolfbjarne · 2021-10-05T16:20:45Z

src/appkit.cs

+		[IgnoredInDelegate]
+		[Export ("application:handlerForIntent:")]
+		[return: NullAllowed]
+		NSObject GetApplication (NSApplication application, INIntent intent);


This is somewhat of a similar case, the important part is what comes after 'application:', so this is a better managed name:

Suggested change

NSObject GetApplication (NSApplication application, INIntent intent);

NSObject GetHandler (NSApplication application, INIntent intent);

rolfbjarne · 2021-10-05T16:20:53Z

src/appkit.cs

+		[Mac (12,0)]
+		[IgnoredInDelegate]
+		[Export ("applicationShouldAutomaticallyLocalizeKeyEquivalents:")]
+		bool ApplicationShouldAutomaticallyLocalizeKeyEquivalents (NSApplication application);


Same:

Suggested change

bool ApplicationShouldAutomaticallyLocalizeKeyEquivalents (NSApplication application);

bool ShouldAutomaticallyLocalizeKeyEquivalents (NSApplication application);

rolfbjarne · 2021-10-05T16:21:06Z

src/appkit.cs

+
+		[Mac (12,0)]
+		[Export ("applicationProtectedDataWillBecomeUnavailable:")]
+		void ApplicationProtectedDataWillBecomeUnavailable (NSNotification notification);


Suggested change

void ApplicationProtectedDataWillBecomeUnavailable (NSNotification notification);

void ProtectedDataWillBecomeUnavailable (NSNotification notification);

rolfbjarne · 2021-10-05T16:21:14Z

src/appkit.cs

+
+		[Mac (12,0)]
+		[Export ("applicationProtectedDataDidBecomeAvailable:")]
+		void ApplicationProtectedDataDidBecomeAvailable (NSNotification notification);


Suggested change

void ApplicationProtectedDataDidBecomeAvailable (NSNotification notification);

void ProtectedDataDidBecomeAvailable (NSNotification notification);

rolfbjarne · 2021-10-05T16:35:26Z

src/appkit.cs

+		[Async]
+		[Mac (12,0)]
+		[Export ("setDefaultApplicationAtURL:toOpenContentTypeOfFileAtURL:completionHandler:")]
+		void SetDefaultApplicationToOpenContentType (NSUrl applicationURL, NSUrl url, [NullAllowed] Action<NSError> completionHandler);


Suggested change

void SetDefaultApplicationToOpenContentType (NSUrl applicationURL, NSUrl url, [NullAllowed] Action<NSError> completionHandler);

void SetDefaultApplicationToOpenContentType (NSUrl applicationUrl, NSUrl url, [NullAllowed] Action<NSError> completionHandler);

rolfbjarne · 2021-10-05T16:35:46Z

src/appkit.cs

+		[Async]
+		[Mac (12,0)]
+		[Export ("setDefaultApplicationAtURL:toOpenFileAtURL:completionHandler:")]
+		void SetDefaultApplicationToOpenFile (NSUrl applicationURL, NSUrl url, [NullAllowed] Action<NSError> completionHandler);


Suggested change

void SetDefaultApplicationToOpenFile (NSUrl applicationURL, NSUrl url, [NullAllowed] Action<NSError> completionHandler);

void SetDefaultApplicationToOpenFile (NSUrl applicationUrl, NSUrl url, [NullAllowed] Action<NSError> completionHandler);

rolfbjarne · 2021-10-05T16:37:24Z

src/appkit.cs

+		[Mac (12,0)]
+		[Export ("URLForApplicationToOpenContentType:")]
+		[return: NullAllowed]
+		NSUrl URLForApplication (UTType contentType);


I think this have to be a bit more explicit to be understandable:

Suggested change

NSUrl URLForApplication (UTType contentType);

NSUrl GetUrlForApplicationToOpenContentType (UTType contentType);

rolfbjarne · 2021-10-05T16:37:48Z

src/appkit.cs

+
+		[Mac (12,0)]
+		[Export ("URLsForApplicationsToOpenContentType:")]
+		NSUrl[] URLsForApplications (UTType contentType);


Suggested change

NSUrl[] URLsForApplications (UTType contentType);

NSUrl[] GetUrlsForApplicationsToOpenContentType (UTType contentType);

rolfbjarne · 2021-10-05T16:38:47Z

src/appkit.cs

+		[Async]
+		[Mac (12,0)]
+		[Export ("setDefaultApplicationAtURL:toOpenContentType:completionHandler:")]
+		void SetDefaultApplication (NSUrl applicationURL, UTType contentType, [NullAllowed] Action<NSError> completionHandler);


Suggested change

void SetDefaultApplication (NSUrl applicationURL, UTType contentType, [NullAllowed] Action<NSError> completionHandler);

void SetDefaultApplicationToOpenContentType (NSUrl applicationURL, UTType contentType, [NullAllowed] Action<NSError> completionHandler);

vs-mobiletools-engineering-service2 · 2021-10-05T20:08:02Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 102 tests passed 🎉

Pipeline on Agent XAMBOT-1100.BigSur'
Merge 517fbd9 into a300dfc

rachelkang · 2021-10-05T20:23:19Z

@rolfbjarne thank you! updated based on your feedback

vs-mobiletools-engineering-service2 · 2021-10-06T00:51:05Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 101 tests passed.

Failed tests

link sdk/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 1458b03 into 67e1ca5

tj-devel709 · 2021-10-06T13:49:25Z

src/appkit.cs

+		[Mac (12,0)]
+		[Static]
+		[Export ("allowedClassesForRestorableStateKeyPath:")]
+		Class[] GetAllowedClassesForRestorableStateKeyPath (string keyPath);


Wondering if this name could exclude KeyPath since it is the parameter name.
Swift name in the docs is allowedClasses(forRestorableStateKeyPath:)
but would GetAllowedClassesForRestorableState (string keyPath) work here?

thanks! I'll just simplify to GetAllowedClasses then - I think RestorableStateKeyPath is one thing, so it could be confusing to imply its for the restorablestate and not specify the keypath

tj-devel709 · 2021-10-06T13:50:32Z

src/appkit.cs

+	[BaseType (typeof (NSCell))]
+	interface NSTextAttachmentCell : NSTextAttachmentCellProtocol {
+		[Export ("initImageCell:")]
+		IntPtr Constructor (NSImage  image);


Suggested change

IntPtr Constructor (NSImage image);

IntPtr Constructor (NSImage image);

nit

tj-devel709 · 2021-10-06T13:54:15Z

Added a small formatting change and a suggestion about the KeyPath! Everything else looks great to me! :)

vs-mobiletools-engineering-service2 · 2021-10-06T15:09:53Z

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 21db142 into 2bc66b0

rachelkang · 2021-10-06T15:13:47Z

/azp run

azure-pipelines · 2021-10-06T15:14:07Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2021-10-06T19:29:52Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 101 tests passed.

Failed tests

dont link/Mac Catalyst [dotnet]/Release [dotnet]: Failed (Test run crashed (exit code: 134).
Tests run: 11 Passed: 6 Inconclusive: 0 Failed: 0 Ignored: 5)

Pipeline on Agent XAMBOT-1097.BigSur'
Merge 21db142 into 2bc66b0

rachelkang · 2021-10-07T13:51:24Z

failing test not related #10833

[AppKit] Update Xcode 13.0 bindings for betas 1,2,3,4,5

517fbd9

rachelkang added the note-highlight Worth calling out specifically in release notes label Oct 5, 2021

rachelkang added this to the xcode13.0 milestone Oct 5, 2021

rachelkang requested a review from dalexsoto October 5, 2021 16:00

rachelkang requested a review from chamons as a code owner October 5, 2021 16:00

rachelkang commented Oct 5, 2021

View reviewed changes

rolfbjarne requested changes Oct 5, 2021

View reviewed changes

Update based on feedback

1458b03

rachelkang requested a review from rolfbjarne October 5, 2021 20:23

rolfbjarne approved these changes Oct 6, 2021

View reviewed changes

tj-devel709 reviewed Oct 6, 2021

View reviewed changes

Update based on feedback

21db142

dalexsoto approved these changes Oct 7, 2021

View reviewed changes

rachelkang merged commit 9ebf14e into xamarin:main Oct 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AppKit] Update Xcode 13.0 bindings for betas 1,2,3,4,5 #12936

[AppKit] Update Xcode 13.0 bindings for betas 1,2,3,4,5 #12936

rachelkang commented Oct 5, 2021

rachelkang Oct 5, 2021

rolfbjarne Oct 5, 2021

rachelkang Oct 5, 2021

rolfbjarne left a comment

rolfbjarne Oct 5, 2021

rolfbjarne Oct 5, 2021

rolfbjarne Oct 5, 2021

rolfbjarne Oct 5, 2021

rolfbjarne Oct 5, 2021

rolfbjarne Oct 5, 2021

rolfbjarne Oct 5, 2021

rolfbjarne Oct 5, 2021

rolfbjarne Oct 5, 2021

rolfbjarne Oct 5, 2021

vs-mobiletools-engineering-service2 commented Oct 5, 2021

rachelkang commented Oct 5, 2021

vs-mobiletools-engineering-service2 commented Oct 6, 2021

Failed tests

tj-devel709 Oct 6, 2021

rachelkang Oct 6, 2021

tj-devel709 Oct 6, 2021 •

edited

Loading

tj-devel709 commented Oct 6, 2021

vs-mobiletools-engineering-service2 commented Oct 6, 2021

rachelkang commented Oct 6, 2021

azure-pipelines bot commented Oct 6, 2021

vs-mobiletools-engineering-service2 commented Oct 6, 2021

Failed tests

rachelkang commented Oct 7, 2021

	bool ApplicationSupportsSecureRestorableState (NSApplication application);
	bool SupportsSecureRestorableState (NSApplication application);

	NSObject GetApplication (NSApplication application, INIntent intent);
	NSObject GetHandler (NSApplication application, INIntent intent);

	bool ApplicationShouldAutomaticallyLocalizeKeyEquivalents (NSApplication application);
	bool ShouldAutomaticallyLocalizeKeyEquivalents (NSApplication application);

	void ApplicationProtectedDataWillBecomeUnavailable (NSNotification notification);
	void ProtectedDataWillBecomeUnavailable (NSNotification notification);

	void ApplicationProtectedDataDidBecomeAvailable (NSNotification notification);
	void ProtectedDataDidBecomeAvailable (NSNotification notification);

	void SetDefaultApplicationToOpenContentType (NSUrl applicationURL, NSUrl url, [NullAllowed] Action<NSError> completionHandler);
	void SetDefaultApplicationToOpenContentType (NSUrl applicationUrl, NSUrl url, [NullAllowed] Action<NSError> completionHandler);

	void SetDefaultApplicationToOpenFile (NSUrl applicationURL, NSUrl url, [NullAllowed] Action<NSError> completionHandler);
	void SetDefaultApplicationToOpenFile (NSUrl applicationUrl, NSUrl url, [NullAllowed] Action<NSError> completionHandler);

	NSUrl URLForApplication (UTType contentType);
	NSUrl GetUrlForApplicationToOpenContentType (UTType contentType);

	NSUrl[] URLsForApplications (UTType contentType);
	NSUrl[] GetUrlsForApplicationsToOpenContentType (UTType contentType);

	void SetDefaultApplication (NSUrl applicationURL, UTType contentType, [NullAllowed] Action<NSError> completionHandler);
	void SetDefaultApplicationToOpenContentType (NSUrl applicationURL, UTType contentType, [NullAllowed] Action<NSError> completionHandler);

	IntPtr Constructor (NSImage image);
	IntPtr Constructor (NSImage image);

[AppKit] Update Xcode 13.0 bindings for betas 1,2,3,4,5 #12936

[AppKit] Update Xcode 13.0 bindings for betas 1,2,3,4,5 #12936

Conversation

rachelkang commented Oct 5, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rolfbjarne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Oct 5, 2021

✅ [PR Build] Tests passed on Build. ✅

API diff

API & Generator diff

GitHub pages

🎉 All 102 tests passed 🎉

rachelkang commented Oct 5, 2021

vs-mobiletools-engineering-service2 commented Oct 6, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tj-devel709 Oct 6, 2021 • edited Loading

Choose a reason for hiding this comment

tj-devel709 commented Oct 6, 2021

vs-mobiletools-engineering-service2 commented Oct 6, 2021

🔥 Tests failed catastrophically on Build (no summary found). 🔥

rachelkang commented Oct 6, 2021

azure-pipelines bot commented Oct 6, 2021

vs-mobiletools-engineering-service2 commented Oct 6, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

rachelkang commented Oct 7, 2021

tj-devel709 Oct 6, 2021 •

edited

Loading