[msbuild] Add ILStrip'ing for net6 applications. Fixes #11445. #12563

chamons · 2021-08-26T19:26:37Z

Controlled by EnableAssemblyILStripping which defaults to true
Integration test included

Before - https://gist.github.com/chamons/c7886f7bacbc2e5ac5966e4251d13e71
After - https://gist.github.com/chamons/148e1bef22fa336f953f3d02dcf20667

859,136 -> 527,872 managed

Fixes #11445.

- Controled by EnableAssemblyILStripping which defaults to true - Integration test included Before - https://gist.github.com/chamons/c7886f7bacbc2e5ac5966e4251d13e71 After - https://gist.github.com/chamons/148e1bef22fa336f953f3d02dcf20667 859,136 -> 527,872 managed

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

chamons · 2021-08-26T19:28:40Z

Those from #12558 see the last commit for changes.

I've now run this locally in sim and device, and hand tested the follow cases:

Sim - no strip
Device Debug - no strip
Device Release - strip
Device Release set MtouchInterpreter - no strip
Device Release /p:MtouchExtraArgs=--nostrip=true - no strip
Device Release /p:MtouchExtraArgs=--nostrip=false - strip
Device Deug /p:MtouchExtraArgs=--nostrip=false - strip

msbuild/Xamarin.MacDev.Tasks.Core/Tasks/ParseBundlerArgumentsTaskBase.cs

chamons · 2021-08-26T19:32:25Z

tests/dotnet/Makefile

@@ -53,7 +53,11 @@ build-dotnet: $(TARGETS)
 	$(DOTNET6) build size-comparison/MySingleView/dotnet/MySingleView.csproj --runtime ios-arm64 $(COMMON_ARGS) /bl:$@.binlog $(MSBUILD_VERBOSITY)

 run-dotnet: $(TARGETS)
-	$(DOTNET6) build -t:Run size-comparison/MySingleView/dotnet/MySingleView.csproj --runtime ios-arm64 $(COMMON_ARGS)
+	$(DOTNET6) build -t:Run size-comparison/MySingleView/dotnet/MySingleView.csproj --runtime ios-arm64 $(COMMON_ARGS) /bl:$@.binlog $(MSBUILD_VERBOSITY)


Convince mostly. Writing out log is almost free, and being able to test sim was nice.

Target strip-dotnet: can also be removed now :)

and the README updated to document how to preserve the IL for analysis (it's already done for legacy)

chamons · 2021-08-26T19:37:45Z

You know, let me try removing that and see what needs to change.

…o il_strip_net6

chamons · 2021-08-26T19:58:45Z

So turns out my more generic conditions work in either case, so I could just remove it.

spouliot · 2021-08-26T20:29:20Z

msbuild/Xamarin.MacDev.Tasks.Core/Tasks/ParseBundlerArgumentsTaskBase.cs

@@ -130,6 +133,10 @@ public override bool Execute ()
 							xml = new List<string> ();
 						xml.Add (value);
 						break;
+					case "nostrip":
+						// Output is EnableAssemblyILStripping so we enable if --nostring=false and disable if true


typo: nostring -> nostrip

spouliot · 2021-08-26T20:33:05Z

tests/dotnet/Makefile

@@ -53,7 +53,11 @@ build-dotnet: $(TARGETS)
 	$(DOTNET6) build size-comparison/MySingleView/dotnet/MySingleView.csproj --runtime ios-arm64 $(COMMON_ARGS) /bl:$@.binlog $(MSBUILD_VERBOSITY)

 run-dotnet: $(TARGETS)
-	$(DOTNET6) build -t:Run size-comparison/MySingleView/dotnet/MySingleView.csproj --runtime ios-arm64 $(COMMON_ARGS)
+	$(DOTNET6) build -t:Run size-comparison/MySingleView/dotnet/MySingleView.csproj --runtime ios-arm64 $(COMMON_ARGS) /bl:$@.binlog $(MSBUILD_VERBOSITY)


Target strip-dotnet: can also be removed now :)

and the README updated to document how to preserve the IL for analysis (it's already done for legacy)

emaf · 2021-08-27T00:00:31Z

dotnet/targets/Xamarin.Shared.Sdk.targets

+			<_StrippedAssemblies Include="@(_AssembliesToBeStripped->'%(OutputPath)')" >
+			</_StrippedAssemblies>
+		</ItemGroup>
+		<ILStrip Assemblies="@(_AssembliesToBeStripped)" />


When building from Windows this won't be executed remotely because it's missing the SessionId property. Does this need to be executed on a Mac? Do we own this task?

The runtime team owns it: https://github.com/dotnet/runtime/pull/57359/files

And yes, this has to be executed on the Mac (it happens after the AOT compiler has executed, but before we sign the final .app)

Okay, this won't work then, for executing a task remotely we need to add the SessionId property and the logic to execute it remotely based on that value. We had the same problem with ILLink, and we ended up inheriting from the original task to add support for remoting it, see https://github.com/xamarin/xamarin-macios/blob/main/msbuild/Xamarin.iOS.Tasks/Tasks/ILLink.cs and https://github.com/xamarin/xamarin-macios/blob/main/msbuild/Xamarin.iOS.Tasks.Core/Tasks/ILLinkBase.cs. The base class is adding input and output properties for all the files that need to be copied to the Mac and the output ones that need to be created on Windows. I'm not sure if there's a better way for doing this.

@emaf I think @chamons can try to implement this but can you help us testing it?

Taking a stab at this.

@dalexsoto I'll be out next week, but @mauroa should be able to help with any questions. Please keep in mind he has many things in his plate already, but he'll try to test this from Windows once the changes are ready.

I think this is fixed.

vs-mobiletools-engineering-service2 · 2021-08-27T03:59:49Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

✅ API Diff (from PR only) (no change)
✅ Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 140 tests passed.

Failed tests

link sdk/Mac Catalyst/Debug: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)
introspection/iOS Unified 64-bits - simulator/Debug [dotnet]: Failed
introspection/iOS Unified 64-bits - simulator/Debug (iOS 11.4) [dotnet]: Failed

Pipeline on Agent XAMBOT-1109.BigSur'
Merge aea669e into 1394420

dotnet/targets/Xamarin.Shared.Sdk.targets

rolfbjarne · 2021-08-27T11:01:25Z

dotnet/targets/Xamarin.Shared.Sdk.targets

+			<_StrippedAssemblies Include="@(_AssembliesToBeStripped->'%(OutputPath)')" >
+			</_StrippedAssemblies>
+		</ItemGroup>
+		<ILStrip Assemblies="@(_AssembliesToBeStripped)" />


The runtime team owns it: https://github.com/dotnet/runtime/pull/57359/files

And yes, this has to be executed on the Mac (it happens after the AOT compiler has executed, but before we sign the final .app)

rolfbjarne · 2021-08-27T11:04:26Z

msbuild/Xamarin.Shared/Xamarin.Shared.targets

@@ -1062,6 +1062,7 @@ Copyright (C) 2018 Microsoft. All rights reserved.
 			<Output TaskParameter="Registrar" PropertyName="_BundlerRegistrar" />
 			<Output TaskParameter="Verbosity" PropertyName="_BundlerVerbosity" />
 			<Output TaskParameter="XmlDefinitions" ItemName="_BundlerXmlDefinitions" />
+			<Output TaskParameter="NoStrip" PropertyName="EnableAssemblyILStripping" />


This task should take EnableAssemblyILStripping as input as well, otherwise it won't be possible for users to override the default by setting EnableAssemblyILStripping to something.

I'm not sure this is correct.

I hacked up a test project: https://gist.github.com/chamons/abe82c128d909df53a1780c792394dab to check

In it, I invoke ParseBundlerArguments with some _BundlerArguments and EnableAssemblyILStripping preset. I print before and after, and I don't think it overrides (with 0f13eb3).

Thoughts on ^?

tests/dotnet/UnitTests/PostBuildTest.cs

emaf · 2021-08-27T13:31:35Z

dotnet/targets/Xamarin.Shared.Sdk.targets

+		<PropertyGroup>
+			<_StrippedAssemblyDirectory>$(DeviceSpecificIntermediateOutputPath)\stripped</_StrippedAssemblyDirectory>
+		</PropertyGroup>
+		<MakeDir Directories="$(_StrippedAssemblyDirectory)" />


This is missing the SessionId parameter and the IsMacEnabled condition, so when building from Windows this will only be executed on Windows. Like this:

xamarin-macios/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Common.targets

Line 364 in 74b161a

<MakeDir SessionId="$(BuildSessionId)" Condition="'$(IsMacEnabled)' == 'true'" Directories="$(_AppResourcesPath)" />

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

vs-mobiletools-engineering-service2 · 2021-09-28T12:37:23Z

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge a027e74 into 5cd7c96

dalexsoto · 2021-09-28T13:46:05Z

/azp run

azure-pipelines · 2021-09-28T13:46:26Z

Azure Pipelines successfully started running 1 pipeline(s).

chamons · 2021-09-28T20:22:57Z

/azp run

azure-pipelines · 2021-09-28T20:23:16Z

Azure Pipelines successfully started running 1 pipeline(s).

mauroa · 2021-09-29T12:05:07Z

@dalexsoto @chamons @rolfbjarne I don't see new packages for the latest changes/fixes in the CI build. Did something go wrong? I would need to have them in order to test VS

rolfbjarne · 2021-09-29T12:17:04Z

/azp run

azure-pipelines · 2021-09-29T12:17:24Z

Azure Pipelines successfully started running 1 pipeline(s).

rolfbjarne · 2021-09-29T12:17:47Z

@mauroa our CI isn't in a nice mood 😒 I started another attempt, hopefully it works this time (third time's the charm!)

vs-mobiletools-engineering-service2 · 2021-09-29T19:44:44Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

✅ API Diff (from PR only) (no change)
✅ Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 134 tests passed.

Failed tests

monotouch-test/Mac [dotnet]/Debug (static registrar) [dotnet]: Failed (Test run failed.
Tests run: 2491 Passed: 2403 Inconclusive: 10 Failed: 1 Ignored: 87)
monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Tests run: 2658 Passed: 2492 Inconclusive: 35 Failed: 1 Ignored: 165)
monotouch-test/tvOS - simulator/Debug (static registrar) [dotnet]: Failed

Pipeline on Agent XAMBOT-1101.BigSur'
Merge f215ae8 into 071b665

vs-mobiletools-engineering-service2 · 2021-09-30T13:45:50Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

✅ API Diff (from PR only) (no change)
✅ Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 136 tests passed.

Failed tests

monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Tests run: 2658 Passed: 2490 Inconclusive: 35 Failed: 3 Ignored: 165)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge ca0cab7 into 7a090e9

lambdageek · 2021-09-30T14:49:00Z

msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Tasks.Core.csproj

@@ -24,6 +25,10 @@
      <!-- We need the net472 impl, otherwise the Build agent needs to be a net5.0 app -->
      <HintPath>$(PkgMicrosoft_NET_ILLink_Tasks)\tools\net472\ILLink.Tasks.dll</HintPath>
    </Reference>
+    <Reference Include="ILStrip">
+      <!-- We need the net472 impl, otherwise the Build agent needs to be a net5.0 app -->
+      <HintPath>$(PkgMicrosoft_NET_Runtime_MonoTargets_Sdk)\tasks\net472\ILStrip.dll</HintPath>


FYI, for net7 I'm looking at consolidating the MonoTargets tasks into a single assembly dotnet/runtime#59720

chamons · 2021-10-04T10:32:57Z

1 test failure is known:

https://github.com/xamarin/maccore/issues/2443

The other two seem obviously related.

chamons · 2021-10-04T10:35:52Z

@mauroa - I just had to re-merge due to a test file conflict but hopefully the last build is good enough to test today?

vs-mobiletools-engineering-service2 · 2021-10-04T18:06:26Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

✅ API Diff (from PR only) (no change)
✅ Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 135 tests passed.

Failed tests

monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Tests run: 2659 Passed: 2491 Inconclusive: 35 Failed: 3 Ignored: 165)
dont link/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)

Pipeline on Agent XAMBOT-1101.BigSur'
Merge f5c2845 into ee14ab7

mauroa · 2021-10-05T14:30:08Z

@chamons @rolfbjarne @dalexsoto I tested with the latest build and I was able to successfully build a net6 ios app with ILStrip enabled. I think we are good to signoff and merge the PR if everything else is ok

rolfbjarne · 2021-10-05T14:41:28Z

Test failures are unrelated

monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: https://github.com/xamarin/maccore/issues/2443
dont link/Mac Catalyst [dotnet]/Debug [dotnet]: https://github.com/xamarin/maccore/issues/2414

- In a late minute change to the ILStrip PR (xamarin#12563) a change XVS support broke execution of Apps that were stripped - Applications were broken because none of the stripped assemblies were actually copied into the bundle - However, the tests still passed, because all assemblies that were there had no IL (zero assemblies total) Now why did this happen? - The stripped assemblies were changed to return via an msbuidl Output Element - Output Element can return an Property or ItemGroup, depending if you use the PropertyName or ItemName attributes - Unfortuntely I used PropertyName, when I expected an ItemGroup. So I silently had a property created instead. - Thus zero items were added to the list of files to copy into the bundle - Which was undetected as the test did not confirm files were copied in, and manual tests were not run so late into the PR (3 weeks after PR was opened) How was it fixed? - Correctly using ItemName on Output created a valid item group to reference - However, that still failed with an absurdly confusing error: PATH/Microsoft.NET.Publish.targets(277,5): error MSB3024: Could not copy the file FILE to the destination file PATH, because the destination is a folder instead of a file. To copy the source file into a folder, consider using the DestinationFolder parameter instead of DestinationFiles. - After a splunking through netcore targets, I found the metadata on these assemblies references really matters. Without it, they are not processed correctly at all. - Thus, I updated ILStripBase to clone the existing metadata when changing the orignal assembly reference to the stripped path - Finally, I corrected the test to assert that required files are copied in. I also manually ran our device test.

- In a late minute change to the ILStrip PR (xamarin#12563) a change to support XVS support broke execution of Apps that were stripped - Applications were broken because none of the stripped assemblies were actually copied into the bundle - However, the tests still passed, because all assemblies that were there had no IL (zero assemblies total) Now why did this happen? - The stripped assemblies were changed to return via an msbuild Output Element - Output Element can return an Property or ItemGroup, depending if you use the PropertyName or ItemName attributes - Unfortunately I used PropertyName, when I expected an ItemGroup. So I silently had a property created instead. - Thus zero items were added to the list of files to copy into the bundle - Which was undetected as the test did not confirm files were copied in, and manual tests were not run so late into the PR (3 weeks after PR was opened) How was it fixed? - Correctly using ItemName on Output created a valid item group to reference - However, that still failed with an absurdly confusing error: PATH/Microsoft.NET.Publish.targets(277,5): error MSB3024: Could not copy the file FILE to the destination file PATH, because the destination is a folder instead of a file. To copy the source file into a folder, consider using the DestinationFolder parameter instead of DestinationFiles. - After a splunking through netcore targets, I found the metadata on these assemblies references really matters. Without it, they are not processed correctly at all. - Thus, I updated ILStripBase to clone the existing metadata when changing the original assembly reference to the stripped path - Finally, I corrected the test to assert that required files are copied in. I also manually ran our device test.

* [net6] Fix ILStrip'ed apps to actually work again - In a late minute change to the ILStrip PR (#12563) a change to support XVS support broke execution of Apps that were stripped - Applications were broken because none of the stripped assemblies were actually copied into the bundle - However, the tests still passed, because all assemblies that were there had no IL (zero assemblies total) Now why did this happen? - The stripped assemblies were changed to return via an msbuild Output Element - Output Element can return an Property or ItemGroup, depending if you use the PropertyName or ItemName attributes - Unfortunately I used PropertyName, when I expected an ItemGroup. So I silently had a property created instead. - Thus zero items were added to the list of files to copy into the bundle - Which was undetected as the test did not confirm files were copied in, and manual tests were not run so late into the PR (3 weeks after PR was opened) How was it fixed? - Correctly using ItemName on Output created a valid item group to reference - However, that still failed with an absurdly confusing error: PATH/Microsoft.NET.Publish.targets(277,5): error MSB3024: Could not copy the file FILE to the destination file PATH, because the destination is a folder instead of a file. To copy the source file into a folder, consider using the DestinationFolder parameter instead of DestinationFiles. - After a splunking through netcore targets, I found the metadata on these assemblies references really matters. Without it, they are not processed correctly at all. - Thus, I updated ILStripBase to clone the existing metadata when changing the original assembly reference to the stripped path - Finally, I corrected the test to assert that required files are copied in. I also manually ran our device test. Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

- In a late minute change to the ILStrip PR (xamarin#12563) a change to support XVS support broke execution of Apps that were stripped - Applications were broken because none of the stripped assemblies were actually copied into the bundle - However, the tests still passed, because all assemblies that were there had no IL (zero assemblies total) Now why did this happen? - The stripped assemblies were changed to return via an msbuild Output Element - Output Element can return an Property or ItemGroup, depending if you use the PropertyName or ItemName attributes - Unfortunately I used PropertyName, when I expected an ItemGroup. So I silently had a property created instead. - Thus zero items were added to the list of files to copy into the bundle - Which was undetected as the test did not confirm files were copied in, and manual tests were not run so late into the PR (3 weeks after PR was opened) How was it fixed? - Correctly using ItemName on Output created a valid item group to reference - However, that still failed with an absurdly confusing error: PATH/Microsoft.NET.Publish.targets(277,5): error MSB3024: Could not copy the file FILE to the destination file PATH, because the destination is a folder instead of a file. To copy the source file into a folder, consider using the DestinationFolder parameter instead of DestinationFiles. - After a splunking through netcore targets, I found the metadata on these assemblies references really matters. Without it, they are not processed correctly at all. - Thus, I updated ILStripBase to clone the existing metadata when changing the original assembly reference to the stripped path - Finally, I corrected the test to assert that required files are copied in. I also manually ran our device test.

…rk again (#13106) * [net6] Fix ILStrip'ed apps to actually work again - In a late minute change to the ILStrip PR (#12563) a change to support XVS support broke execution of Apps that were stripped - Applications were broken because none of the stripped assemblies were actually copied into the bundle - However, the tests still passed, because all assemblies that were there had no IL (zero assemblies total) Now why did this happen? - The stripped assemblies were changed to return via an msbuild Output Element - Output Element can return an Property or ItemGroup, depending if you use the PropertyName or ItemName attributes - Unfortunately I used PropertyName, when I expected an ItemGroup. So I silently had a property created instead. - Thus zero items were added to the list of files to copy into the bundle - Which was undetected as the test did not confirm files were copied in, and manual tests were not run so late into the PR (3 weeks after PR was opened) How was it fixed? - Correctly using ItemName on Output created a valid item group to reference - However, that still failed with an absurdly confusing error: PATH/Microsoft.NET.Publish.targets(277,5): error MSB3024: Could not copy the file FILE to the destination file PATH, because the destination is a folder instead of a file. To copy the source file into a folder, consider using the DestinationFolder parameter instead of DestinationFiles. - After a splunking through netcore targets, I found the metadata on these assemblies references really matters. Without it, they are not processed correctly at all. - Thus, I updated ILStripBase to clone the existing metadata when changing the original assembly reference to the stripped path - Finally, I corrected the test to assert that required files are copied in. I also manually ran our device test. * Update tests/dotnet/UnitTests/PostBuildTest.cs Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: Chris Hamons <chris.hamons@xamarin.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

chamons and others added 3 commits August 25, 2021 14:31

Apply suggestions from code review

87c5c96

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Rework EnableAssemblyILStripping conditions

fb4fef5

chamons requested review from emaf and rolfbjarne as code owners August 26, 2021 19:26

chamons mentioned this pull request Aug 26, 2021

[msbuild] Add ILStrip'ing for net6 applications #12558

Closed

Merge branch 'main' into il_strip_net6

7b355ed

chamons requested a review from spouliot August 26, 2021 19:28

chamons commented Aug 26, 2021

View reviewed changes

msbuild/Xamarin.MacDev.Tasks.Core/Tasks/ParseBundlerArgumentsTaskBase.cs Outdated Show resolved Hide resolved

chamons commented Aug 26, 2021

View reviewed changes

chamons added the note-highlight Worth calling out specifically in release notes label Aug 26, 2021

chamons added 2 commits August 26, 2021 14:57

Remove questionable set

0f13eb3

Merge branch 'il_strip_net6' of github.com:chamons/xamarin-macios int…

cf78956

…o il_strip_net6

filipnavara approved these changes Aug 26, 2021

View reviewed changes

spouliot approved these changes Aug 26, 2021

View reviewed changes

Code review comments

aea669e

dalexsoto approved these changes Aug 26, 2021

View reviewed changes

emaf reviewed Aug 27, 2021

View reviewed changes

rolfbjarne added the run-dotnet-tests Run all the .NET tests label Aug 27, 2021

rolfbjarne requested changes Aug 27, 2021

View reviewed changes

emaf requested changes Aug 27, 2021

View reviewed changes

rolfbjarne changed the title ~~[msbuild] Add ILStrip'ing for net6 applications~~ [msbuild] Add ILStrip'ing for net6 applications. Fixes #11445. Aug 27, 2021

chamons and others added 4 commits August 27, 2021 09:23

Update tests/dotnet/UnitTests/PostBuildTest.cs

cce0c87

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Apply suggestions from code review

80bc6f1

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Extend BuildIpaTest to include strip testing

1c30a7f

Fix makedir missing windows tags

8abf282

Merge branch 'main' into il_strip_net6

f215ae8

Merge branch 'main' into il_strip_net6

ca0cab7

lambdageek mentioned this pull request Sep 30, 2021

Build one MonoTargetsTasks assembly for Microsoft.NET.Runtime.MonoTargets.Sdk pack dotnet/runtime#59720

Merged

lambdageek reviewed Sep 30, 2021

View reviewed changes

Merge branch 'main' into il_strip_net6

f5c2845

chamons merged commit a300dfc into xamarin:main Oct 5, 2021

chamons deleted the il_strip_net6 branch October 5, 2021 14:43

chamons mentioned this pull request Oct 22, 2021

[net6] Fix ILStrip'ed apps to actually work again #13098

Merged

vs-mobiletools-engineering-service2 mentioned this pull request Oct 25, 2021

[release/6.0.1xx-preview10] [net6] Fix ILStrip'ed apps to actually work again #13106

Merged

[msbuild] Add ILStrip'ing for net6 applications. Fixes #11445. #12563

[msbuild] Add ILStrip'ing for net6 applications. Fixes #11445. #12563

Conversation

chamons commented Aug 26, 2021 • edited Loading

chamons commented Aug 26, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chamons commented Aug 26, 2021

chamons commented Aug 26, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emaf Aug 27, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Aug 27, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Sep 28, 2021

🔥 Tests failed catastrophically on Build (no summary found). 🔥

dalexsoto commented Sep 28, 2021

azure-pipelines bot commented Sep 28, 2021

chamons commented Sep 28, 2021

azure-pipelines bot commented Sep 28, 2021

mauroa commented Sep 29, 2021

rolfbjarne commented Sep 29, 2021

azure-pipelines bot commented Sep 29, 2021

rolfbjarne commented Sep 29, 2021

vs-mobiletools-engineering-service2 commented Sep 29, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Sep 30, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

Choose a reason for hiding this comment

chamons commented Oct 4, 2021

chamons commented Oct 4, 2021

vs-mobiletools-engineering-service2 commented Oct 4, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

mauroa commented Oct 5, 2021

rolfbjarne commented Oct 5, 2021

chamons commented Aug 26, 2021 •

edited

Loading

emaf Aug 27, 2021 •

edited

Loading