[CoreData] Add support for Xcode 13 beta 3. #12183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandel-macaque
added
the
note-highlight
spouliot
suggested changes
Jul 22, 2021
src/coredata.cs
Outdated
| @@ -1667,14 +1671,26 @@ interface NSPersistentHistoryTransaction : NSCopying | |||
| [DisableDefaultCtor] // NSInternalInconsistencyException Reason: NSCoreDataCoreSpotlightDelegate requires the use of the initializer initForStoreWithDescription:model: | |||
| interface NSCoreDataCoreSpotlightDelegate | |||
| { | |||
|
|
|||
| [Notification] | |||
| [NoWatch, NoTV, Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | |||
There was a problem hiding this comment.
[NoWatch] and [NoTV] are already present on the type declaration and does not need to be repeated on members
src/coredata.cs
Outdated
| void StartSpotlightIndexing (); | ||
|
|
||
| [NoWatch, NoTV, Mac (12,0), iOS (15,0)] | ||
| [Export ("stopSpotlightIndexing"), MacCatalyst (15,0)] |
There was a problem hiding this comment.
it's legit - but it's confusing to mix availability and [Export] inside the same [...]
| [Async (ResultTypeName = "NSPersistentCloudKitContainerAcceptShareInvitationsResult")] | ||
| [Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
| [Export ("acceptShareInvitationsFromMetadata:intoPersistentStore:completion:")] | ||
| void AcceptShareInvitations (CKShareMetadata[] metadata, NSPersistentStore persistentStore, [NullAllowed] NSPersistentCloudKitContainerAcceptShareInvitationsHandler handler); |
There was a problem hiding this comment.
the NSPersistentCloudKitContainerAcceptShareInvitationsHandler has [NoWatch] and [NoTV] attributes
| [Async (ResultTypeName = "NSPersistentCloudKitContainerPurgeObjectsAndRecordsInZone")] | ||
| [Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
| [Export ("purgeObjectsAndRecordsInZoneWithID:inPersistentStore:completion:")] | ||
| void PurgeObjectsAndRecordsInZone (CKRecordZoneID zoneId, [NullAllowed] NSPersistentStore persistentStore, [NullAllowed] NSPersistentCloudKitContainerPurgeObjectsAndRecordsInZoneHandler handler); |
| [Async (ResultTypeName = "NSPersistentCloudKitContainerPersistUpdatedShareResult")] | ||
| [Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
| [Export ("persistUpdatedShare:inPersistentStore:completion:")] | ||
| void PersistUpdatedShare (CKShare share, NSPersistentStore persistentStore, [NullAllowed] NSPersistentCloudKitContainerPersistUpdatedShareHandler handler); |
| [Async (ResultTypeName = "NSPersistentCloudKitContainerFetchParticipantsMatchingLookupInfosResult")] | ||
| [Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
| [Export ("fetchParticipantsMatchingLookupInfos:intoPersistentStore:completion:")] | ||
| void FetchParticipantsMatchingLookupInfos (CKUserIdentityLookupInfo[] lookupInfos, NSPersistentStore persistentStore, NSPersistentCloudKitContainerFetchParticipantsMatchingLookupInfosHandler handler); |
| [Async (ResultTypeName = "NSPersistentCloudKitContainerShareManagedObjectsResult")] | ||
| [Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
| [Export ("shareManagedObjects:toShare:completion:")] | ||
| void ShareManagedObjects (NSManagedObject[] managedObjects, [NullAllowed] CKShare share, NSPersistentCloudKitContainerShareManagedObjectsHandler handler); |
There was a problem hiding this comment.
All these methods, I got the first interface wrong and forgot to update the delegates, updated in a9c9067
rolfbjarne
approved these changes
Jul 22, 2021
spouliot
approved these changes
Jul 22, 2021
tj-devel709
reviewed
Jul 22, 2021
| [Export ("startSpotlightIndexing")] | ||
| void StartSpotlightIndexing (); | ||
|
|
||
| [NoWatch, NoTV, Mac (12,0), iOS (15,0),MacCatalyst (15,0)] |
There was a problem hiding this comment.
Suggested change
| [NoWatch, NoTV, Mac (12,0), iOS (15,0),MacCatalyst (15,0)] | |
| [NoWatch, NoTV, Mac (12,0), iOS (15,0), MacCatalyst (15,0)] |
tj-devel709
approved these changes
Jul 22, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 87 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096.BigSur' |
|
/sudo backport release/6.0.1xx-preview7 |
|
Backport Job to branch release/6.0.1xx-preview7 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5013301 for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.