Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GameController] Add support for xcode 13 beta3. #12144

Merged
merged 2 commits into from
Jul 20, 2021
Merged

[GameController] Add support for xcode 13 beta3. #12144

merged 2 commits into from
Jul 20, 2021

Conversation

mandel-macaque
Copy link
Member

No description provided.

@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Jul 19, 2021
@mandel-macaque mandel-macaque requested a review from spouliot as a code owner July 19, 2021 22:01
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2493 Inconclusive: 35 Failed: 1 Ignored: 135)

Pipeline on Agent XAMBOT-1096.BigSur'
Merge aaed4e4 into e968a93

rolfbjarne
rolfbjarne approved these changes Jul 20, 2021
View reviewed changes
src/gamecontroller.cs Outdated Show resolved Hide resolved
spouliot
spouliot approved these changes Jul 20, 2021
View reviewed changes
src/gamecontroller.cs Outdated Show resolved Hide resolved
@mandel-macaque @rolfbjarne
Address method rename.
98d690c 
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@mandel-macaque
Copy link
Member Author

Test failure is unrelated.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

  • introspection/Mac Catalyst/Debug: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)

Pipeline on Agent XAMBOT-1098.BigSur'
Merge 98d690c into 3c38f8c

@mandel-macaque mandel-macaque merged commit 4d329df into xamarin:main Jul 20, 2021
@mandel-macaque mandel-macaque deleted the gamecontroller-xcode13-beta3 branch July 20, 2021 19:40
@rolfbjarne
Copy link
Member

/sudo backport release/6.0.1xx-preview7

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.1xx-preview7 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5002433 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelkang rachelkang rachelkang approved these changes

@spouliot spouliot spouliot approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

Assignees
No one assigned
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mandel-macaque @vs-mobiletools-engineering-service2 @rolfbjarne @spouliot @rachelkang