Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeviceCheck] Updates for Xcode13 beta 1 #12074

Merged
merged 2 commits into from
Jul 7, 2021
Merged

[DeviceCheck] Updates for Xcode13 beta 1 #12074

merged 2 commits into from
Jul 7, 2021

Conversation

tj-devel709
Copy link
Contributor

No description provided.

@tj-devel709 tj-devel709 added the not-notes-worthy Ignore for release notes label Jul 1, 2021
@tj-devel709 tj-devel709 added this to the xcode13.0 milestone Jul 1, 2021
@tj-devel709 tj-devel709 requested a review from spouliot as a code owner July 1, 2021 23:11
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 3b122e6 into 20dc67f

rachelkang
rachelkang approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just remember to update the wiki!

@rachelkang rachelkang added note-highlight Worth calling out specifically in release notes and removed not-notes-worthy Ignore for release notes labels Jul 7, 2021
@tj-devel709
Copy link
Contributor Author

looks great! just remember to update the wiki!

Oh man, I didn't even claim this one! Thanks for catching that!

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

  • link sdk/Mac Catalyst/Debug: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 48a3c23 into 3b6f059

@tj-devel709
Copy link
Contributor Author

Unrelated failing test: https://github.com/xamarin/maccore/issues/2434

@tj-devel709 tj-devel709 merged commit ab151a7 into xamarin:main Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelkang rachelkang rachelkang approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@spouliot spouliot Awaiting requested review from spouliot

Assignees
No one assigned
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
xcode13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tj-devel709 @vs-mobiletools-engineering-service2 @mandel-macaque @rachelkang