-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutomaticAssessmentConfiguration] Updates for Xcode13 beta1 #12070
[AutomaticAssessmentConfiguration] Updates for Xcode13 beta1 #12070
Conversation
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 86 tests passed 🎉Pipeline on Agent XAMBOT-1104.BigSur' |
|
||
[NoiOS, Mac (12,0), MacCatalyst (15,0)] | ||
[Export ("assessmentSessionDidUpdate:")] | ||
void DidUpdate (AEAssessmentSession session); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No iOS but MacCatalyst? That is weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah.. that is interesting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the docs, is is correct, and that is why I approved, it is just funny that Catalyst was meant to be iOS apps that run on Mac, yet they do things like this. 🍎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just wondering - what does this part of the diff signify? How should it be addressed? (from the wiki)
-API_AVAILABLE(ios(13.4), macos(10.15.4), macCatalyst(14))
-extern NSErrorDomain const AEAssessmentErrorDomain;
+AE_VISIBLE NSErrorDomain const AEAssessmentErrorDomain API_AVAILABLE(ios(13.4), macos(10.15.4), macCatalyst(14));
That's a good question. It just looked like noise to me and did not show up on the todos so I just ignored it. Perhaps @mandel-macaque has the answer? |
That is noise, someone changing a MACRO, I don't know why they change the macros EVERY YEAR. It is noise. |
No description provided.