[dotnet] use copyOnly for .png files in templates #12016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/templating#3325 Context: https://github.com/dotnet/templating/wiki/Reference-for-template.json#content-manipulation In current .NET 6 Preview 6 builds, there is an issue if a template includes a binary file larger than ~8kb, it seems to get truncated when `dotnet new` extracts the template. A workaround is to use the `copyOnly` feature for binary files. Really, we should be doing this anyway, because otherwise the templating system considers replacing *text* in these binary files. It improves performance to do this and would hopefully prevent a future bug of random bytes getting replaced.
|
We'll probably want to also backport this to Preview 6. |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 111 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
rolfbjarne
approved these changes
Jun 25, 2021
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2414). |
|
/sudo backport release/6.0.1xx-preview6 |
|
Backport Job to branch release/6.0.1xx-preview6 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4913340 for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/templating#3325
Context: https://github.com/dotnet/templating/wiki/Reference-for-template.json#content-manipulation
In current .NET 6 Preview 6 builds, there is an issue if a template
includes a binary file larger than ~8kb, it seems to get truncated when
dotnet newextracts the template.A workaround is to use the
copyOnlyfeature for binary files. Really,we should be doing this anyway, because otherwise the templating system
considers replacing text in these binary files. It improves
performance to do this and would hopefully prevent a future bug of
random bytes getting replaced.